WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#3227 closed defect (bug) (fixed)

Thumbnails hidden under Manage > Uploads

Reported by: filosofo Owned by: matt
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords: upload thumbnail css
Focuses: Cc:

Description

Image thumbnails under Manage > Uploads are hidden in Firefox 1.5 thanks to the line-height setting under "#upload-files a.file-link.image {"

Attached patch just deletes the line-height setting.

Attachments (2)

upload.css.diff (6.0 KB) - added by filosofo 8 years ago.
upload.css.2.diff (278 bytes) - added by filosofo 8 years ago.

Download all attachments as: .zip

Change History (14)

filosofo8 years ago

comment:1 follow-up: Viper007Bond8 years ago

You need a better diff program. :/

comment:2 in reply to: ↑ 1 westi8 years ago

Replying to Viper007Bond:

You need a better diff program. :/

I think its more he needs a better editor.

It's changed all the line endings from [CR][LF] to [LF] hence making the diff file annoyingly large.

filosofo8 years ago

comment:3 follow-up: filosofo8 years ago

Oops, sorry about that. Has trac started using a different file format? I've never had this problem before. Maybe someone has started using a Mac to create these files? The editor is nano, and now I have to specify that it not convert file types.

Anyways, the new diff should be better.

Thanks!

comment:4 in reply to: ↑ 3 ; follow-up: foolswisdom8 years ago

Replying to filosofo:

Has trac started using a different file format?

Trac was upgraded over the weekend, but I don't think SVN was, which I would would be responsible for the raw formatting.

I do see that http://trac.wordpress.org/browser/trunk/wp-admin/upload.css does not have the native-eol attribute.

comment:5 in reply to: ↑ 4 westi8 years ago

Replying to foolswisdom:

Replying to filosofo:

Has trac started using a different file format?

Trac was upgraded over the weekend, but I don't think SVN was, which I would would be responsible for the raw formatting.

I do see that http://trac.wordpress.org/browser/trunk/wp-admin/upload.css does not have the native-eol attribute.

native-eol is probably the issue here true

comment:6 matt7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4547]) Prevent uploads from being hidden, fixes #3227

comment:7 mdawaffe7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm using FF 1.5.0.8 and do not have this problem with the old CSS. Could there be another cause that's somehow tied to the line-height so that changing that "fixes" it?

Line-height was the only way I was able to get vertical centering to work cross browser. Now pictures are not centered within the blue boxes.

If someone else can confirm the bug, I can open a new vertical centering ticket.

comment:8 follow-up: filosofo7 years ago

Hmm. I see the problem using Firefox 1.5.0.1 on Linux but not Firefox 1.5.0.8 on Windows. (Konqueror has the problem but only for slightly-larger-than-normal thumbnails.)

It seems to be caused by the fact that the line-height setting is making the   before each image really big, pushing the image down out of view.

comment:9 ryan7 years ago

  • Owner changed from anonymous to matt
  • Status changed from reopened to new

comment:10 in reply to: ↑ 8 foolswisdom7 years ago

  • Keywords has-patch removed

Replying to filosofo:

Hmm. I see the problem using Firefox 1.5.0.1... Konqueror...

Based on currently only having this problem reported on back version maintenance build of Firefox and identified version of Konqueror, and the problems for vertical centering, may be best to back out this change.

comment:11 foolswisdom7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Matt suggested closing as resolved FIXED.

mdawaffe has the ball in this area, and has been doing other improvements here.

comment:12 foolswisdom7 years ago

Created #3619 for 2.2 .

Note: See TracTickets for help on using tickets.