Thumbnails hidden under Manage > Uploads

[filosofo]

Image thumbnails under Manage > Uploads are hidden in Firefox 1.5 thanks to the line-height setting under "#upload-files a.file-link.image {"

Attached patch just deletes the line-height setting.

[Viper007Bond]

You need a better diff program. :/

[westi]

Replying to Viper007Bond:

You need a better diff program. :/

I think its more he needs a better editor.

It's changed all the line endings from [CR][LF] to [LF] hence making the diff file annoyingly large.

[filosofo]

Oops, sorry about that. Has trac started using a different file format? I've never had this problem before. Maybe someone has started using a Mac to create these files? The editor is nano, and now I have to specify that it not convert file types.

Anyways, the new diff should be better.

Thanks!

[foolswisdom]

Replying to filosofo:

Has trac started using a different file format?

Trac was upgraded over the weekend, but I don't think SVN was, which I would would be responsible for the raw formatting.

I do see that ​http://trac.wordpress.org/browser/trunk/wp-admin/upload.css does not have the native-eol attribute.

[westi]

Replying to foolswisdom:

Replying to filosofo:

Has trac started using a different file format?

Trac was upgraded over the weekend, but I don't think SVN was, which I would would be responsible for the raw formatting.

I do see that ​http://trac.wordpress.org/browser/trunk/wp-admin/upload.css does not have the native-eol attribute.

native-eol is probably the issue here true

[matt]

(In [4547]) Prevent uploads from being hidden, fixes #3227

[mdawaffe]

I'm using FF 1.5.0.8 and do not have this problem with the old CSS. Could there be another cause that's somehow tied to the line-height so that changing that "fixes" it?

Line-height was the only way I was able to get vertical centering to work cross browser. Now pictures are not centered within the blue boxes.

If someone else can confirm the bug, I can open a new vertical centering ticket.

[filosofo]

Hmm. I see the problem using Firefox 1.5.0.1 on Linux but not Firefox 1.5.0.8 on Windows. (Konqueror has the problem but only for slightly-larger-than-normal thumbnails.)

It seems to be caused by the fact that the line-height setting is making the   before each image really big, pushing the image down out of view.

[foolswisdom]

Replying to filosofo:

Hmm. I see the problem using Firefox 1.5.0.1... Konqueror...

Based on currently only having this problem reported on back version maintenance build of Firefox and identified version of Konqueror, and the problems for vertical centering, may be best to back out this change.

[foolswisdom]

Matt suggested closing as resolved FIXED.

mdawaffe has the ball in this area, and has been doing other improvements here.

[foolswisdom]

Created #3619 for 2.2 .