Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#32294 closed defect (bug) (fixed)

Focus style: Switch View links

Reported by: afercia's profile afercia Owned by: ocean90's profile ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: General Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

Splitting this out from #29897. See screenshot before and after patch.

https://cldup.com/GKbP8j2e9o.png

Attachments (2)

32294.patch (1.6 KB) - added by afercia 11 years ago.
32294.2.patch (2.6 KB) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (8)

@afercia
11 years ago

#1 @afercia
11 years ago

In the proposed patch:

  • Fix the focus style for the Switch View links in the Posts listings and Media Library.

#2 follow-up: @ocean90
11 years ago

I think we should remove the 5px left margin from .view-switch > a + a to put both links a bit together again.

@afercia
11 years ago

#3 in reply to: ↑ 2 @afercia
11 years ago

Replying to ocean90:

I think we should remove the 5px left margin from .view-switch > a + a to put both links a bit together again.

Yup, I'm also wondering if the child selector > is really needed in all the other rules, I don't see any reason for that. The previous patch missed the color change on focus, tried to simplify selectors and clean up a bit and all appears to work fine. Also, the clickable area should probably be a bit bigger on smaller screens, see screenshot below:

https://cldup.com/iVJuyhIuHQ.png

#4 @afercia
11 years ago

In the refreshed patch:

  • Fix the focus style for the Switch View links in the Posts listings and Media Library, remove margin between links, simplify CSS selectors and make the clickable area bigger on smaller screens.

#5 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 32485:

Improve focus styles for the Switch View links in Posts listings and Media Library.

props afercia.
fixes #32294.

#6 @ocean90
11 years ago

  • Milestone changed from Awaiting Review to 4.3
Note: See TracTickets for help on using tickets.