WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#32298 closed enhancement (fixed)

Remove convert to smilies option

Reported by: chriscct7 Owned by: pento
Milestone: 4.3 Priority: normal
Severity: normal Version: 1.2
Component: Formatting Keywords:
Focuses: administration Cc:
PR Number:

Description

Given smilies are pretty much deprecated, and the (default on) option to turn :-) into smily is barely used by anyone, we should consider removing it (strongly related #5161). We have a filter for turning that off if users really want to use this. This along with #5161 would remove an entire section of barely used options from the admin, simplifying the settings and following core philosophy of decisions not options

Does anyone have an objection to this?

Change History (9)

#1 @SergeyBiryukov
5 years ago

  • Component changed from Administration to Formatting

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


5 years ago

#3 @pento
5 years ago

  • Keywords 2nd-opinion dev-feedback removed
  • Milestone changed from Awaiting Review to 4.3
  • Version set to 1.2

See 5161#comment:16.

(Smilies will definitely be going away, but I'm waiting for opinions on balance tags before them both.)

#4 @pento
5 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 32454:

On the Writing Options screen, hide the Balance Tags and Convert Smilies options on new installs.

Fixes #5161.
Fixes #32298.

#5 @celloexpressions
5 years ago

Why only on new installs? Do we expect significant opposition from existing installs? It seems like these would typically be set once, then left, so removing the option on an existing install shouldn't be much of an issue either.

#6 @pento
5 years ago

Historically, there've been two ways of removing options:

  • [23588], where we only remove it for new installs.
  • [21539], where it's removed when the option setting is the default value.

I went with removing it on new installs only for a couple of reasons:

  • There's no extra functionality that depends on it being removed.
  • I'm more inclined to think that people will play with formatting settings more freely, and having them magically disappear seems like a weird (and potentially off-putting) UX.

#7 @netweb
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

r32454 should be reverted, bbPress and BuddyPress both use convert_smilies() and we're far from the only two plugins, see https://github.com/search?q=user%3Awp-plugins+convert_smilies&type=Code

Per the current releases of bbPress and BuddyPress I'd expect to be able to install WordPress 4.3 and the respective bbPress or BuddyPress versions and be able to enable this option to Convert emoticons like :-) and :-P to graphics on display and have this smiliey post content continued to be rendered graphically.

The change in r32454 removes this capability for new installs with existing plugins, I agree that this is a good decision that should be made but not right now, plugins should be given sufficient time to implement this change before forcing their hand.

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


5 years ago

#9 @pento
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 32455:

When saving Writing Options, check that the UI is enabled for use_smilies and use_balanceTags before trying to update them.

Fixes #5161.
Fixes #32298.

Note: See TracTickets for help on using tickets.