Changes between Version 1 and Version 2 of Ticket #32315, comment 19
- Timestamp:
- 11/01/2016 03:28:04 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #32315, comment 19
v1 v2 7 7 1. finish generating the SQL, put it in `$wpdb->last_query` etc, but not run the query? (I think this would be the most helpful to folks, but it might be confusing for someone reading the code that we detect a error but wait to abort the process.) Or 8 8 9 2. s hould `$wpdb->last_query` be set to a empty string (indicating no query ran)? or9 2. set `$wpdb->last_query` to a empty string (indicating no query ran)? 10 10 11 3. s hould it be set tosome sort of descriptive phrase like "WordPress was about to insert values(x, y, z) into columns (w,v,r), but column 't' was too small" (this has the advantage of allowing us to abort the execution right away, but we're not creating actual SQL like we normally would)?11 3. set `$wpdb->last_query` to be some sort of descriptive phrase like "WordPress was about to insert values(x, y, z) into columns (w,v,r), but column 't' was too small" (this has the advantage of allowing us to abort the execution right away, but we're not creating actual SQL like we normally would)? 12 12 13 13 Or something else?