Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #32315, comment 32


Ignore:
Timestamp:
10/27/2017 10:42:48 PM (7 years ago)
Author:
mnelson4
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32315, comment 32

    initial v1  
    11> I don't think that the other places that it can return false are important to handle
    22
    3 +1, if we want to tackle those, let's do those on another ticket (maybe we should rename this ticket to specify its only for failures when the value is too big for the column or contains invalid data)?)
     3+1, if we want to tackle those, let's do those on another ticket (maybe we should rename this ticket to specify its only for failures when the value is too big for the column or contains invalid data?)
    44
    55> I've included some basic unit tests in the patch as well.