Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#3233 closed defect (bug) (fixed)

'Editor' tab title needs clarifier for translation

Reported by: foolswisdom Owned by: foolswisdom
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords:
Focuses: Cc:


Stefano wrote to wp-testers Oct 12, 2006 3:12 AM

Subject: [wp-testers] i18n issue

The RTE tab is named Editor, but this string is used for a role too, so the translation for both is unique, in Italian but i suppose in other languages the role is translated in a different way than the RTE's name.

Attachments (2)

3233.patch (798 bytes) - added by foolswisdom 15 years ago.
Include HTML comment as proposed by MarkJaquith
3233-2.patch (999 bytes) - added by foolswisdom 15 years ago.

Download all attachments as: .zip

Change History (10)

15 years ago

Include HTML comment as proposed by MarkJaquith

#1 @Viper007Bond
15 years ago

  • Keywords has-patch added
  • Milestone set to 2.1
  • Version set to 2.1

#2 @andy
15 years ago

I dig it

#3 @markjaquith
15 years ago

Ryan Boren says on wp-hackers:

Maybe use a custom tag that is stripped by () and _e(). Translators can leave the tag in the translated text or omit it.


#4 @foolswisdom
15 years ago

  • Keywords has-patch removed

Oops, did not mean to add has-patch until after I tested. I should not have attached it I guess, or put in a comment right away.

HTML comment solution does not work, shows up on label. Guess input value can't include comments. Maybe can be escaped, but Ryan's solution seems more elegant and generalizes.

#5 @matt
15 years ago

I know we had a reason for choosing "editor" but given its existing context within WordPress as a publishing system perhaps we should reconsider that choice?

Personally I would be fine with Visual / Code or Visual / HTML.

I'm not a fan of adding another layer of compexity to our translation system.

#6 @foolswisdom
15 years ago

In light of everything, "Visual" seems like a win/win/win. I am indifferent whether the other is "Code" or "HTML".

#7 @foolswisdom
15 years ago

  • Owner changed from anonymous to foolswisdom

No longer indifferent as RTE are often referred as HTML editor (gmail for example), so Visual / Code seems like the winningest to me.

I will attach the trivial patch.

15 years ago

#8 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4476]) Visual and Code. Props foolswisdom. fixes #3233

Note: See TracTickets for help on using tickets.