Twenty Fifteen: Add Missing Social Link Genericons

[philiparthurmoore]

Skype and Path are missing. See screenshots and attached patch.

[lancewillett]

Thanks for this, Philip.

[lancewillett]

@philiparthurmoore I think the CSS rule should use asterisk (*) instead of dollar sign ($) for those two additions.

[philiparthurmoore]

Replying to lancewillett:

@philiparthurmoore I think the CSS rule should use asterisk (*) instead of dollar sign ($) for those two additions.

Gah. You're right. New patch coming shortly.

[lancewillett]

In 32497:

Twenty Fifteen: add missing social link Genericons styles for Skype and Path.

Fixes #32332, props philiparthurmoore.

[iamtakashi]

Just FYI, we removed Skype intentionally. See #30059.

[iamtakashi]

I don't use Path so I don't know much about it, but is there each user's public facing page with a url in Path?

[philiparthurmoore]

Thanks for the comments, Takashi. My thinking behind this was that the social icons are available in Genericons, and the only two missing from Twenty Fifteen, so that seemed like an oversight. I totally missed #30059. Does every single social network that's supported in Twenty Fifteen have (or need to have) a public profile URL? I thought that these social icons were supposed to have parity with Genericons first, and then take into consideration the public profile URL next, so didn't think about whether or not a public URL exists for the icons, when path.com and skype.com links would suffice as well. Why would someone want to put an empty Path or Skype top level URL into their social menu? Not sure, but the missing icons felt weird. :) Thanks for referencing that older ticket.

[philiparthurmoore]

Replying to philiparthurmoore:

Does every single social network that's supported in Twenty Fifteen have (or need to have) a public profile URL?

For example, polldaddy.com comes to mind. I'm sure there are others. Probably much too late to get into auditing those services for public profile URLs?

[iamtakashi]

I can't tell with a confident if all supported services have public facing user's pages but I couldn't find it straight away in Path, that's why I didn't add the support, and I removed Skype for the reason in the ticket.

But, if we really think the support should depend on what icons available in Genericons, I don't mind adding the support for those services.

Does anyone have an opinion on this?

[obenland]

If you can't link to those social networks we probably don't need to support them.

[philiparthurmoore]

I'm fine with either approach. So maybe revert this fix, and in future themes that support social networks make sure they have public-facing links?

[lancewillett]

I'm happy to leave it as-is. Skype links technically work—and someone might want to have that protocol in their menu.