Make WordPress Core

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#32334 closed enhancement (fixed)

Removing some not needed context

Reported by: pavelevap's profile pavelevap Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: I18N Keywords: has-patch
Focuses: Cc:


There are several "Mark as Spam" strings with different context. But we can merge string without context.

Also "In Response To" is needed for one context.

We can merge similar strings:

Invalid comment ID.
Oops, no comment with this ID.

See attached patch...

It would be also helpfull to merge following strings, I guess:

In reply to: <b><a href="%1$s">%2$s</a></b>
In reply to <a href="%1$s">%2$s</a>.

Something like "In reply to %s" would be fine for both cases. I can try to create patch if approved...

Attachments (1)

32334.patch (2.9 KB) - added by pavelevap 9 years ago.

Download all attachments as: .zip

Change History (6)

9 years ago

#1 @MikeHansenMe
9 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by jorbin. View the logs.

8 years ago

#3 @jorbin
8 years ago

  • Type changed from defect (bug) to enhancement

@ocean90 or @SergeyBiryukov - Could one of you take a look at the this patch please.

#4 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33436:

Comment string tweaks:

  • Merge two strings about an invalid comment ID.
  • Add missing context to 'Mark as Spam' string.
  • Merge two 'In Response To' strings, replace redundant context with a translator comment.

props pavelevap.
fixes #32334.

#5 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 4.3
Note: See TracTickets for help on using tickets.