WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 17 months ago

#32348 closed enhancement (wontfix)

Remove CSS styling of Microformats/Hatom elements in Bunded Themes

Reported by: dshanske Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Related to #32336, rewrite of bundled themes in wordpress(2013-2015 as of now) to remove styling of hatom/microformats class as styling should not be based on any semantic element.

Specifically, removal of CSS styling based on the hentry class, as well as hfeed, entry-content, entry-title, entry-summary, vcard...basically any of the classes used as part of microformats.

http://microformats.org/wiki/hatom

Suggesting that this be noted as a recommended(but not required) practice noted as part of the guidelines for themes submitted for wordpress.org

Change History (7)

#1 @obenland
4 years ago

  • Component changed from Themes to Bundled Theme

#2 @obenland
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

In #32336 I said I don't see a reason why it's not worth proposing. Thinking about it a bit more, this is probably not something that will be changed in any existing default theme for backwards compatibility reasons (child themes overwriting those .hentry styles).

It is however something that we can make sure won't happen in Twenty Sixteen. /cc @karmatosed @iamtakashi

#3 in reply to: ↑ description @iamtakashi
4 years ago

Replying to dshanske:

Specifically, removal of CSS styling based on the hentry class, as well as hfeed, entry-content, entry-title, entry-summary, vcard...basically any of the classes used as part of microformats.

Sorry for my ignorance but could you clarify more "why" we should not use those classes for styling?

Last edited 4 years ago by iamtakashi (previous) (diff)

#4 follow-up: @dshanske
4 years ago

I'll give you the most prevalent example. WordPress applies hentry incorrectly by applying it to everything. Due to the fact that so many people used it as a style element, it can't be applied correctly without breaking a lot of sites.

This is the best example of why you shouldn't style semantic classes in WordPress today.

#5 in reply to: ↑ 4 @iamtakashi
4 years ago

Replying to dshanske:

Thanks, @dshanske.

You've also suggested to not to use entry-title, entry-content, and other classes that are on the page in microformats.org too. Could you also let me know why? Are they also misused in the past default themes?

#6 @dshanske
4 years ago

HFeed is consistently misused on themes and applied to all pages instead of just archive pages. Entry-title, entry-content, etc are usually used correctly...but if you want to change how the semantic markup of the page works, you shouldn't have to also adjust your style.

Note: See TracTickets for help on using tickets.