WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #32360, comment 13


Ignore:
Timestamp:
09/03/2016 12:12:13 AM (3 years ago)
Author:
johnbillion
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32360, comment 13

    initial v1  
    55I guess it makes sense for the tests to remain in a group which never gets tested by default (ie. without passing the `--group external-oembed` flag), but then I'm not sure if that's super valuable.
    66
    7 In addition, the `testOembedProviderReturnsExpectedResponse()` test really needs to be split into several smaller tests so that every assertion can be performed (as opposed to the test failing at the first assertion failure). This means moving the actual HTTP requests into a data provider.
     7~~In addition, the `testOembedProviderReturnsExpectedResponse()` test really needs to be split into several smaller tests so that every assertion can be performed (as opposed to the test failing at the first assertion failure). This means moving the actual HTTP requests into a data provider.~~