Filter in `wp_get_attachment_image_src`

[eclev91]

I’ve been working on a plugin for filler images on posts without thumbnails so that during development I’m not swamping the media library with things I have to delete later.

I can hook into post_thumbnail_html and check if the HTML is empty, which does the trick for things like get_post_thumbnail(), but sometimes I may use the post thumbnail as a background image, so I use wp_get_attachment_image_src instead, which doesn't call the aforementioned hook. It’d be nice to be able to hook in there as well. Other suggestions would be great, but I'll be working on a patch.

[eclev91]

Run filter on return no matter what

[eclev91]

Syntax error resolved, tested with use case

[johnbillion]

This'll need a ​hook docblock and probably a better name for the filter. attachment_image_src is probably most appropriate.

[eclev91]

Added docblock, changed name of filter

[MikeHansenMe]

fixes some code sniffer errors

[obenland]

@johnbillion, do you have time to get it in before beta?

[wonderboymusic]

In 32866:

Add a filter in wp_get_attachment_image_src() called attachment_image_src.

Props eclev91, MikeHansenMe.
Fixes #32363.

[DrewAPicture]

Docs + rename to wp_get_attachment_image_src

[DrewAPicture]

Since we're filtering the actual return of wp_get_attachment_image_src(), I think we should name the filter the same thing. In 32363.diff​ I've adjusted the name and fixed the spacing within the DocBlock.

[johnbillion]

I don't think the filter name needs to be tied to the function name. The filter is for the attachment image source, so attachment_image_src makes sense.

Doc changes look good.

[wonderboymusic]

In 32949:

After [32866], fix doc blocks.

Props DrewAPicture.
See #32363.

[wonderboymusic]

The only thing left is (potential) name change of the filter. Up to you.

[obenland]

In 33018:

After [32866], change filter name.

While filter names generally don't have to be tied to the function in which they
are applied, the API for media display generally seems to use the
wp_get_attachment_* pattern.

Props DrewAPicture.
Fixes #32363.

[swissspidy]

#29702 was marked as a duplicate.