WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 4 years ago

#32367 closed enhancement (maybelater)

Nav menu attribute unit tests

Reported by: johnbillion's profile johnbillion Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Menus Keywords: needs-unit-tests
Focuses: Cc:

Description (last modified by johnbillion)

I'll be introducing unit tests for nav menu attributes; primarily for class names on menu items.

This will allow us to investigate and hopefully fix the following tickets:

Other relevant closed tickets:

Change History (17)

#1 @johnbillion
10 years ago

  • Owner set to johnbillion
  • Status changed from new to assigned

#2 @johnbillion
10 years ago

  • Description modified (diff)

#3 @johnbillion
10 years ago

  • Description modified (diff)

#4 @obenland
9 years ago

No movement in 5 weeks, how much of a difference will two more weeks make until we hit beta in 4.3?

#5 @obenland
9 years ago

  • Milestone changed from 4.3 to Future Release

#6 @johnbillion
9 years ago

  • Milestone changed from Future Release to 4.3

Nearly there with this.

This ticket was mentioned in ​Slack in #core by obenland. ​View the logs.
9 years ago

This ticket was mentioned in ​Slack in #core by obenland. ​View the logs.
9 years ago

#9 @obenland
9 years ago

  • Milestone changed from 4.3 to Future Release

No patch, let's try it in a future release.

#10 @johnbillion
9 years ago

  • Owner johnbillion deleted

This is more of a pain than I expected, so I'm taking it off my radar for now.

#11 @johnbillion
9 years ago

  • Keywords needs-unit-tests added

This ticket was mentioned in ​Slack in #core by johnbillion. ​View the logs.
9 years ago

#13 @mdgl
8 years ago

In addition to those listed in the description, there are further tickets requiring attention, notably: #34839, #32918 and #28620. Looks like we have quite a few issues in this area. Is anyone daring enough to pick this up? The code in and surrounding _wp_menu_item_classes_by_context() is pretty opaque :-)

#15 @welcher
8 years ago

@johnbillion I wrote some tests for menu-item classes on 35272 so I can be any help on this I'd love to lend a hand.

#16 @welcher
8 years ago

38486 would benefit as well

#17 @johnbillion
4 years ago

  • Resolution set to maybelater
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.