Urls are encoded incorrectly in WP_Posts_List_Table::get_views()

[BdN3504]

I stumbled upon this bug when I tried to fix something else: The current css class is not added to the 'All' link in the views. To solve this issue, I added the css class with DOMDocument. But when I called the method to read the html of

$views['all']

like so:

DOMDocument::loadHTML($views['all'])

, I received a parsing error. The parsing error is thrown because the ampersand in WP_Posts_List_Table::get_views() on line 185 is not encoded.
I will refrain from using my DOMDocument method of fixing the other bug, I will file another bug instead, because I now know why the 'current' css class is not added to the 'All' view.

[BdN3504]

A patch fixing the issue.

[wonderboymusic]

I did some work here. See 32376.diff​

[wonderboymusic]

In 34084:

WP_Posts_List_Table: there are a cadre of edit.php URLs that are generated by string-building instead of using our handy functions. Create a helper method, ->get_edit_link() that standardizes the generation and escaping of these URLs.

Props BdN3504 for the initial patch on the ticket.
Fixes #32376.

[DrewAPicture]

Documentation for this new method is incomplete:

• Need docs for all three parameters, including marking the third one optional
• The summary needs a period and should not contain markdown backticks
• Needs an @access tag

[SergeyBiryukov]

In 34238:

Docs: Expand the DocBlock for the WP_Theme::get_edit_link() method, introduced in [34084].

Fixes #32376.