Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#32391 closed defect (bug) (fixed)

About page: not enough space for localized navigation links

Reported by: pavelevap's profile pavelevap Owned by: helen's profile helen
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Help/About Keywords: has-patch
Focuses: ui Cc:

Description

After redirecting to About page (after WP update), there is not enough space for translated navigation links bellow. But there is enough space available, so it should not be a problem even if translation is longer then original?

See attached screenshot.

Attachments (3)

About_page_links_bellow.jpg (10.5 KB) - added by pavelevap 9 years ago.
32391.patch (462 bytes) - added by tyxla 9 years ago.
In about.php, stretch the .return-to-dashboard section to width: 100% to support the longer localized links. Also adding div tagname as prefix to the .return-to-dashboard classname to override the .about-wrap .two-col > div rule, avoiding !important usage.
32391.2.patch (855 bytes) - added by tyxla 9 years ago.
Moving .return-to-dashboard where it belongs

Download all attachments as: .zip

Change History (10)

@tyxla
9 years ago

In about.php, stretch the .return-to-dashboard section to width: 100% to support the longer localized links. Also adding div tagname as prefix to the .return-to-dashboard classname to override the .about-wrap .two-col > div rule, avoiding !important usage.

#1 @tyxla
9 years ago

  • Keywords has-patch added

Just added a quick fix that will expand the container of the links to take all the available width, allowing longer localized links. The div tagname was added to override the .about-wrap .two-col > div rule, avoiding !important usage.

#2 @SergeyBiryukov
9 years ago

  • Component changed from General to Help/About
  • Focuses ui added
  • Milestone changed from Awaiting Review to 4.3

#3 @helen
9 years ago

  • Keywords needs-patch added; has-patch removed

Seems to me the <hr> and return-to-dashboard div need to move out of the feature-section div. feature-section has a border-bottom too, then no need for the <hr> anymore.

#4 @tyxla
9 years ago

@helen +1.

Looking at the HTML in about.php it appears that the .return-to-dashboard has been wrongly inserted in the .feature-section in the first place. Attaching a new patch that moves .return-to-dashboard to the correct place, and also the <hr> is removed as unnecessary, because of the .feature-section bottom border.

With this, the CSS modification that the previous patch was doing is not necessary.

@tyxla
9 years ago

Moving .return-to-dashboard where it belongs

#5 @tyxla
9 years ago

  • Keywords has-patch added; needs-patch removed

#6 @helen
9 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 32636:

About: Give bottom navigation links the full width.

This will prevent longer strings from wrapping needlessly, and is more semantically correct markup.

props tyxla.
fixes #32391.

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


7 years ago

Note: See TracTickets for help on using tickets.