WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #32417, comment 97


Ignore:
Timestamp:
02/15/17 17:47:13 (9 months ago)
Author:
afercia
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32417, comment 97

    v1 v2  
    1111- Usability: in the modal, I can actually select a .pdf, .doc, .zip, or other files types and nothing happens: ideally, the media modal should filter the attachments in order to show only the allowed ones. Or, at least use a warning when trying to insert: "this media type is not allowed" 
    1212- JavaScript: not translatable strings, e.g. 'Use as widget', 'Select Media'. Not sure about the usage of 'Change Media' as sort of fallback 
    13 - JavaScript (minor): many properties name don't need quotes, only reserved names and names with hyphens need them, e.g. `'class'` or `'data-id'` 
     13- JavaScript (minor): many properties names don't need quotes, only reserved names and names with hyphens need them, e.g. `'class'` or `'data-id'` 
    1414- PHP: most of the uses of `extract()` were removed from core, no other widgets uses it. I'd recommend to avoid to introduce new ones. See #22400.  
    1515- PHP: not sure why hidden fields should be inside a `<fieldset>` element, which is a semantic element used in this case for  elements that are not perceivable