WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 9 months ago

#32428 closed task (blessed) (fixed)

Do not e-mail passwords

Reported by: markjaquith Owned by: markjaquith
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Security Keywords: has-patch
Focuses: administration Cc:

Description

When creating an account for someone in WordPress, this is a bad time to let the user-creator pick a password. First, we’re risking that it’s weak, but even if it isn’t weak, it isn’t going to memorable for the actual user who will own the account. In this case, we should just generate a password, and send the user a password view/reset link. For situations without e-mail, we can let the creator see the password, and send it to the user via a more secure than e-mail method.

Attachments (3)

32428.diff (2.5 KB) - added by MikeHansenMe 4 years ago.
Send a set password link instead of plaintext password
32428.2.diff (2.5 KB) - added by MikeHansenMe 4 years ago.
add time to hash for expiring passwords
32428-login.diff (668 bytes) - added by Ipstenu 4 years ago.
Change registration page to say that registration confirmation will be sent

Download all attachments as: .zip

Change History (21)

This ticket was mentioned in Slack in #core-passwords by mark. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by mark. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by mark. View the logs.


4 years ago

@MikeHansenMe
4 years ago

Send a set password link instead of plaintext password

#5 @MikeHansenMe
4 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core-passwords by mikehansenme. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by mark. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-passwords by mikehansenme. View the logs.


4 years ago

@MikeHansenMe
4 years ago

add time to hash for expiring passwords

#9 @MikeHansenMe
4 years ago

32428.2.diff add time() to the hash so that it will expire properly.

#10 @obenland
4 years ago

  • Owner set to markjaquith
  • Status changed from new to assigned

@Ipstenu
4 years ago

Change registration page to say that registration confirmation will be sent

#11 @Ipstenu
4 years ago

Attached 32428-login.diff

Changing "A password will be e-mailed to you." on the wp-login.php page to "Registration confirmation will be e-mailed to you."

Hat tip to @petercralen - https://wordpress.org/support/topic/registration-set-pasword

This ticket was mentioned in Slack in #core by ipstenu. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-passwords by mikehansenme. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-passwords by mikehansenme. View the logs.


4 years ago

#15 @dd32
4 years ago

Although I haven't tested these patches, they look correct to me.

#17 @obenland
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33265:

Login: Reflect new password flow in registration form.

Props Ipstenu.
Fixes #32428.

#18 @chriscct7
9 months ago

#28168 was marked as a duplicate.

Note: See TracTickets for help on using tickets.