WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#32431 closed enhancement (fixed)

Network Admin Menu has 'upgrades' in it's own subsection, instead of parity with Single Site

Reported by: Ipstenu Owned by: jeremyfelt
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.0
Component: Networks and Sites Keywords: has-patch commit
Focuses: multisite Cc:

Description

On a single instance of WordPress, the 'Dashboard' menu item lists upgrades underneath.

On a multisite, it has it's own section down at the bottom of the menus.

This is annoying as you would expect WordPress to keep upgrades in it's own location consistently. The best explanation I can give for why it's like this is that because multisite has two upgrade links (available updates & upgrade network)

Attached patch moves the menu away from it's own land and over to how it looks on Single.

Attachments (3)

32431.patch (2.3 KB) - added by Ipstenu 3 years ago.
Moving menus
32431.diff (3.0 KB) - added by jeremyfelt 3 years ago.
32431.2.diff (3.1 KB) - added by jeremyfelt 3 years ago.

Download all attachments as: .zip

Change History (11)

@Ipstenu
3 years ago

Moving menus

This ticket was mentioned in Slack in #core-multisite by ipstenu. View the logs.


3 years ago

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 4.3

@jeremyfelt
3 years ago

#3 @jeremyfelt
3 years ago

+1, I like ditching menu items. :) Part of me did like "Dashboard" only being itself and having no sub-menu, but this is good.

32431.diff removes the second wp_get_update_data() call as we can reuse the first.

The notification number wraps below "Available Updates" when hovering over "Dashboard". Looks like it's one pixel off (in Chrome) from the current min-width: 160px; https://cloudup.com/cC5UElrzaiQ

In single site we use "Updates" rather than "Available Updates". Can we do that here too?

#4 @johnjamesjacoby
3 years ago

I haven't reviewed the code changes, but get nervous when anything changes menus code. This one more-so because it's linked to network database upgrade routines that cycle through every site in a network to perform upgrades on each individual one.

Can we specifically confirm that still works?

@jeremyfelt
3 years ago

#5 @jeremyfelt
3 years ago

Replying to jeremyfelt:

In single site we use "Updates" rather than "Available Updates". Can we do that here too?

"Updates" was changed to "Available Updates" in [18026] to avoid a visual clash with the parent "Updates" menu item. I think it's okay to change it back to "Updates" with a move to a different parent menu item.

Replying to johnjamesjacoby:

I haven't reviewed the code changes, but get nervous when anything changes menus code.

I hear you, menus code is uncomfortable to touch. :)

Can we specifically confirm that still works?

I tested locally and everything works as normal for the network upgrades. I don't see anything that relies on the menu position of these items.

My only concern right now is if a plugin is hooking into $submenu['index.php'][10] or $submenu['index.php'][15] and ends up squashing this, but I'm hopeful that's not the case. If so, it's a quick work around to resolve.

32431.2.diff goes with "Updates" and results in views of https://cloudup.com/c2Wxai9NcjG and https://cloudup.com/c7STOqO0uQp.

#6 @Ipstenu
3 years ago

I left it as "Available Updates" because it was that today and I too share the menu changing fear, so I made it as few changes as possible. I did toss the idea of making it "Updates" but went for 'as few changes as possible' :) That looks nice to me too.

But I also tested it locally and had no issues.

I've not seen any plugins that hook into index. If needed, I can figure out an ack to run on the plugin repo and see if anyone is, but most plugins make their own menu (Yoast's SEO, HTTPS) even if they only have one item.

#7 @SergeyBiryukov
3 years ago

  • Keywords has-patch commit added

#8 @jeremyfelt
3 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 32514:

Move network update submenu items to the Network Dashboard menu item

Provides parity with the placement of the "Updates" submenu item in single site.

props Ipstenu.
fixes #32431.

Note: See TracTickets for help on using tickets.