Allow wp_dropdown_languages() to return, instead of output, the markup.

[leewillis77]

This allows the markup created by wp_dropdown_languages() to be re-used by other code without having to resort to output-buffering hacks.

[leewillis77]

Proposed patch.

[obenland]

We should probably create a get_ function for that, rather than introducing another argument.

[leewillis77]

Thanks for the feedback. Any suggestions on how to achieve that without duplicating huge wedges of code or using output_buffering (Or is the use of output buffering acceptable?)

[obenland]

You could let wp_dropdown_languages() display whatever the get_ function returns.

[obenland]

@ocean90 might want to weigh in here as well.

[leewillis77]

Revised patch. Introduces get_dropdown_languages(). Makes wp_dropdown_languages() use this to do the heavy lifting.

[ocean90]

Related: #29362

I'm fine with adding an argument for returning the dropdown,I don't see the need for a get_ function here. We can use the existing $args argument and use echo as the key which is false per default. @leewillis77 do you want to make a new patch for this? For inspiration take a look at wp_dropdown_pages() or wp_dropdown_categories().

[juliobox]

Hello,

i just added my patch using a new array entry named "echo".

See you ;)

[leewillis77]

Updates the docblock in @juliobox's patch to add the new arg.

Thanks

[juliobox]

My bad, thanks

Replying to leewillis77:

Updates the docblock in @juliobox's patch to add the new arg.

Thanks

[SergeyBiryukov]

I don't think we need strict comparison in line 960, if ( $args['echo'] ) (like in wp_dropdown_pages()) should be enough.

[juliobox]

Done.

[SergeyBiryukov]

In 32510:

Allow wp_dropdown_languages() to return the markup instead of displaying.

props leewillis77, juliobox.
fixes #32432.