WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 17 months ago

#32434 closed enhancement (fixed)

Network Admin: Improve the default columns in the MS Sites List Table

Reported by: jeremyfelt Owned by: jeremyfelt
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:

Description

Pulled over from #22383

We can make some improvements to the data displayed in wp-admin/network/sites.php by default.

Currently shown:

  • Subdirectory: Path, Last Updated, Registered, Users
  • Subdomain: Domain, Last Updated, Registered Users

In both cases, "Users" is a list of the first 5 users before showing a "more" link to wp-admin/network/site-users.php for that site. This could be more useful as an overall count of the users linking to the same page.

In the case of a Subdomain configuration, it is possible that domain and path both vary between sites and we should find the right way to show this information. This may be as a full URL or by showing Domain and Path. I don't think it's necessary to show all the information for a Subdirectory configuration, as the Domain would continue to be the same.

Attachments (3)

32434.patch (2.7 KB) - added by ocean90 3 years ago.
32434.2.patch (3.6 KB) - added by ocean90 3 years ago.
Re-adds users column to show user count, https://cloudup.com/cTY5sqDxuzg
32434.3.patch (3.8 KB) - added by ocean90 3 years ago.
Adds caching

Download all attachments as: .zip

Change History (20)

#1 @jeremyfelt
3 years ago

22383.3.diff is the latest patch from @ocean90 with some adjustments.

#2 follow-up: @jeremyfelt
3 years ago

I wouldn't mind seeing a site's (front end) scheme in this view as well, though I'm not sure if that's a popular concern.

#3 in reply to: ↑ 2 @WPMS.CLUB
3 years ago

Replying to jeremyfelt:

I wouldn't mind seeing a site's (front end) scheme in this view as well, though I'm not sure if that's a popular concern.

Seeing scheme in this view would be great =)

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

@ocean90
3 years ago

@ocean90
3 years ago

Re-adds users column to show user count, https://cloudup.com/cTY5sqDxuzg

@ocean90
3 years ago

Adds caching

#7 @ocean90
3 years ago

  • Keywords has-patch added; needs-patch removed

32434.3.patch:

  • Combines Domain/Path to an URL column.
  • Converts the users column to a total count rather than a list of the first 5 users. The count is cached for 12 hours. (I'm using the blog-details group, but I think it's not quite necessary.)

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

#9 @jeremyfelt
3 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 32718:

Improve information displayed in a network's sites list table

  • Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
  • Show a cached count of total users per site as a more useful data point rather than the first 5 users.
  • Clear that cached count of users for a site when a user is added to the site via add_user_to_blog().

Props @ocean90.
Fixes #32434.

#10 @jeremyfelt
3 years ago

In 32719:

Additional improvement to sites list table display

  • Build $blogname identically when creating action link messaging.
  • Remove the trailing slash from URLs for a better UI.

See #32434.

#11 @jeremyfelt
3 years ago

Slack discussion around slashes in the UI for [32719].

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


3 years ago

#15 @jeremyfelt
3 years ago

In 33097:

Remove unused $current_site global in MS Sites list table

Found itself unused after [32719].

See #32434.

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


17 months ago

Note: See TracTickets for help on using tickets.