Upload iframe renders pictures in reverse order

[sapegin]

Attachments are in reverse order when they have menu_order attributes.

It is because this code in get_media_items function:

$attachments = get_children( array( 'post_parent' => $post_id, 'post_type' => 'attachment', 'orderby' => 'menu_order ASC, ID', 'order' => 'DESC') );

Generates this query:

…wp_posts.menu_order DESC, wp_posts.ID DESC…

It should be:

$attachments = get_children( array( 'post_parent' => $post_id, 'post_type' => 'attachment', 'orderby' => array( 'menu_order' => 'ASC', 'ID' => 'DESC') ) );

Which will generate:

…wp_posts.menu_order ASC, wp_posts.ID DESC…

[SergeyBiryukov]

Previously: #16584