Opened 10 years ago
Closed 10 years ago
#32455 closed enhancement (wontfix)
Make the "Static Front Page" customiser section more generic
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 4.2.2 |
Component: | Customize | Keywords: | needs-testing has-patch |
Focuses: | Cc: |
Description
In the customiser there's a section called "Static Front Page". This section is a bit of a problem as it is so specific that really no other fields can really live inside it.
I propose this section be renamed to simply "Front Page", so that for anyone who wants to create front-page specific options, they can be housed under this section rather than having 2 sections.
This would be a nice first step for #29173.
Attachments (1)
Change History (12)
This ticket was mentioned in Slack in #core-customize by paulwilde. View the logs.
10 years ago
#2
@
10 years ago
- Keywords has-patch needs-testing added
The attached patch changes the section title to "Front Page" and the sections of the options in it the front_page
.
Changing the ids didn't change the settings previously set in the section so I don't think we need to convert those further.
#3
@
10 years ago
One other consideration would be to remove the description of "Your theme supports a static front page."
I see that there's a theme_supports argument of "static-front-page" commented out, so I'm guessing this was half-implemented? The only real check I can see is if at least 1 page exists.
#4
@
10 years ago
I think this makes sense especially since the announcement that the trt will start pushing options to the customizer.
#5
follow-up:
↓ 6
@
10 years ago
One concern about changing the section ID is if themes/plugins are currently registering controls expecting that section to be there. If the section ID changes, the controls won't be displayed anymore.
#6
in reply to:
↑ 5
@
10 years ago
- Keywords dev-feedback added
Replying to westonruter:
If the section ID changes, the controls won't be displayed anymore.
Yes, that would be a problem. A quick search shows that quite a few themes are using this so this patch would break that.
Do we just not change only the title of the section and keep the ID as is?
#7
@
10 years ago
- Keywords close added; dev-feedback removed
We definitely can't change the ID. But I don't think we should do this at all. Static front page is a critical part of a site, that likely won't be changed frequently if ever, and is accordingly not theme-specific. Mixing theme-specific options with static front page could lead to user confusion and encourage bad separation of content vs. presentation. When it comes down to it, there really shouldn't be any other options in this section, and if others are added they should probably be added by plugins, not themes. It's not hard to rename this section if you are adding things (using $wp_customize->get_section()->title = 'New Title'), or to just add a new section for theme-related front page settings.
#8
@
10 years ago
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
Going to close this based on no further feedback.
I would strongly discourage themes from adding front page options to this section. Make a "Front Page" or home page section for your theme instead. I imagine that the static front page section could eventually move to a core panel with more fundamental setup-type settings that are unlikely to be changed, such as the site identity section. It's better to keep theme-related options separated from fundamental core settings for this type of thing I think.
#9
@
10 years ago
- Keywords 2nd-opinion dev-feedback added; close removed
- Resolution wontfix deleted
- Status changed from closed to reopened
I agree with his ticket's intentions and disagree with @celloexpressions on closing.
This section could be a place for themes to add front page options. I don'ts ee why not, and such approach is consistent with WordPress admin options pages.
#10
@
10 years ago
Theme options should be available in a single section/panel called "Theme Options".
This approach is clear, straightforward, and ease to understand. Options should not be split up and put into different sections.
I'd propose that we close this ticket. In the end developers want to, and can, change this however they want through various ways. But Core should prioritize what makes sense for users, not demands of--based on this ticket's traction--a few developers.
Changes to section title & id's to Front Page / front_page