New plugin update feature doesn't always recognize errors

[viktorix]

The new same page plugin update feature introduced in 4.2 seems to not always recognize an error that prevents plugin from being updated, showing that it was updated successfully. Once plugin page is reloaded, it shows the same plugin with an available update again.

When I go through the process of using bulk update, it uses the older method of updating plugins with page being reloaded and statuses showed - here you do see errors and that plugin was not updated.

See screenshot:

[dd32]

In 32571:

Updates: Correctly identify more failed update cases. This checks for a WP_Error being raised during an individual update, in addition to just the bootstrap error cases.
The error message in these cases is still not displayed in the UI.

See #32473, #32435

[toddlahman]

#32514 was marked as a duplicate.

[samuelsidler]

@dd32: fixed-major? Or more to do?

[dd32]

It now detects the failure, but still doesn't actually tell the end user what went wrong.

[toddlahman]

@dd32 Is someone scheduled to work on the returned ajax error messages in the next incremental or major release?

[stevenkword]

Replying to toddlahman:

@dd32 Is someone scheduled to work on the returned ajax error messages in the next incremental or major release?

@toddlahman, I've recently started taking a look.

[dd32]

In 32779:

Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
Fixes #32435, #32473

[dd32]

re-opening for 4.2.x, the fix there will need to be a subset of the 4.3 changes

[dd32]

#32219 was marked as a duplicate.

[dd32]

#32086 was marked as a duplicate.

[dd32]

r32779 doesn't work particularly well for cases where the text was destined for a button, for example, on the Add new Plugins page

[dd32]

#32822 was marked as a duplicate.

[dd32]

In 33302:

Updates: Correctly identify more failed update cases.
This checks for a WP_Error being raised during an individual update, in addition to just the bootstrap error cases.
When a error occurs during the connection phase, pass the error message back as the ajax failure message.

Merges [32571] & [32778] to the 4.2 branch

See #32473, #32435

[dd32]

In 33305:

Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.

Merges the behaviour of [32779] to the 4.2 branch without a string change.
See #32435, #32473

[dd32]

Fixed for 4.2.3