WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#32473 closed defect (bug) (fixed)

New plugin update feature doesn't always recognize errors

Reported by: viktorix Owned by: dd32
Milestone: 4.2.3 Priority: normal
Severity: normal Version: 4.2.2
Component: Upgrade/Install Keywords: fixed-major
Focuses: Cc:

Description

The new same page plugin update feature introduced in 4.2 seems to not always recognize an error that prevents plugin from being updated, showing that it was updated successfully. Once plugin page is reloaded, it shows the same plugin with an available update again.

When I go through the process of using bulk update, it uses the older method of updating plugins with page being reloaded and statuses showed - here you do see errors and that plugin was not updated.

See screenshot: http://i.imgur.com/sCHMKny.png

Attachments (1)

plugins-add-new-long-error.png (82.8 KB) - added by dd32 2 years ago.

Download all attachments as: .zip

Change History (18)

#1 @dd32
3 years ago

In 32571:

Updates: Correctly identify more failed update cases. This checks for a WP_Error being raised during an individual update, in addition to just the bootstrap error cases.
The error message in these cases is still not displayed in the UI.

See #32473, #32435

#2 @dd32
3 years ago

  • Milestone changed from Awaiting Review to 4.2.3

#3 @toddlahman
2 years ago

#32514 was marked as a duplicate.

#4 @samuelsidler
2 years ago

@dd32: fixed-major? Or more to do?

#5 @dd32
2 years ago

It now detects the failure, but still doesn't actually tell the end user what went wrong.

#6 follow-up: @toddlahman
2 years ago

@dd32 Is someone scheduled to work on the returned ajax error messages in the next incremental or major release?

#7 in reply to: ↑ 6 @stevenkword
2 years ago

Replying to toddlahman:

@dd32 Is someone scheduled to work on the returned ajax error messages in the next incremental or major release?

@toddlahman, I've recently started taking a look.

#8 @dd32
2 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 32779:

Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
Fixes #32435, #32473

#9 @dd32
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

re-opening for 4.2.x, the fix there will need to be a subset of the 4.3 changes

#10 @dd32
2 years ago

  • Focuses performance removed

#11 @dd32
2 years ago

#32219 was marked as a duplicate.

#12 @dd32
2 years ago

#32086 was marked as a duplicate.

#13 @dd32
2 years ago

r32779 doesn't work particularly well for cases where the text was destined for a button, for example, on the Add new Plugins page

#14 @dd32
2 years ago

#32822 was marked as a duplicate.

#15 @dd32
2 years ago

In 33302:

Updates: Correctly identify more failed update cases.
This checks for a WP_Error being raised during an individual update, in addition to just the bootstrap error cases.
When a error occurs during the connection phase, pass the error message back as the ajax failure message.

Merges [32571] & [32778] to the 4.2 branch

See #32473, #32435

#16 @dd32
2 years ago

In 33305:

Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.

Merges the behaviour of [32779] to the 4.2 branch without a string change.
See #32435, #32473

#17 @dd32
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed for 4.2.3

Note: See TracTickets for help on using tickets.