WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#32475 closed defect (bug) (fixed)

The "Missed Schedule" text in the Posts List Table looks like a link

Reported by: rachelbaker Owned by: helen
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch ui-feedback
Focuses: ui, administration Cc:
PR Number:

Description

The "Missed Schedule" text is blue and looks like a link. Screenshot: ​https://cloudup.com/cLkdkDDzlCU

The text should be red to signal that there is an issue that needs attention.

Attachments (6)

32475.patch​ (614 bytes) - added by rachelbaker 4 years ago.
32475.diff​ (2.7 KB) - added by obenland 4 years ago.
broken-theme-before.png​ (31.1 KB) - added by obenland 4 years ago.
broken-theme-after.png​ (30.3 KB) - added by obenland 4 years ago.
missing-dropin-before.png​ (23.8 KB) - added by obenland 4 years ago.
missing-dropin-after.png​ (23.7 KB) - added by obenland 4 years ago.

Download all attachments as: .zip

Change History (15)

#1 @rachelbaker
4 years ago

  • Component changed from Posts, Post Types to Administration

@rachelbaker
4 years ago

#2 @SergeyBiryukov
4 years ago

  • Component changed from Administration to Posts, Post Types
  • Focuses administration added
  • Milestone changed from Awaiting Review to 4.3

#3 @rachelbaker
4 years ago

  • Focuses ui administration removed
  • Keywords has-patch ui-feedback added
  • Milestone changed from 4.3 to Awaiting Review

Patch changes text to red. Screenshot: ​https://cloudup.com/caLpjUAqmgV

#4 @SergeyBiryukov
4 years ago

  • Focuses ui administration added
  • Milestone changed from Awaiting Review to 4.3

#5 @obenland
4 years ago

.error-message doesn't seem to be used currently, not sure if this one is on the short list for deprecation/removal due to that?

.attention is used in three places, the MS theme list, the plugin list, and the missed schedule. We should consider changing them all if we deem .attention not to be attention-grabbing enough.

#6 @helen
4 years ago

.attention should definitely not be blue. Not sure we're even using it correctly - a broken theme seems like it should be an error. What color would attention be? Should they just all be error-message?

This ticket was mentioned in ​Slack in #design by rachelbaker. ​View the logs.
4 years ago

@obenland
4 years ago

@obenland
4 years ago

@obenland
4 years ago

@obenland
4 years ago

@obenland
4 years ago

#8 @obenland
4 years ago

Added before/after screenshots and a fresh patch, making it all error messages.

#9 @helen
4 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 33117:

Ensure error messages look like, well, errors.

props obenland, rachelbaker.
fixes #32475.

Note: See TracTickets for help on using tickets.