WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#32516 closed defect (bug) (fixed)

Revision 32599 Breaks menus & all other theme_mods_% stored values.

Reported by: brianlayman's profile BrianLayman Owned by: nacin's profile nacin
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: General Keywords:
Focuses: Cc:

Description

Scott's most recent check-in synced into my VIP QuickStart install and I've spent the last 90 minutes trying to figure out what I broke. :D

He moved a return value up into an if statement inside get_theme_mods and it shouldn't be there. As a result, theme_locations is never returned on current dbs.

Diff/patch attached.

Attachments (1)

theme.php.diff​ (317 bytes) - added by BrianLayman 10 years ago.
Patch to get menus et al working again…

Download all attachments as: .zip

Change History (5)

@BrianLayman
10 years ago

Patch to get menus et al working again...

#1 @nacin
10 years ago

  • Milestone changed from Awaiting Review to 4.3

#2 @nacin
10 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 32632:

Fix return error in get_theme_mods() from [32629].

Split a line with both an assignment and a conditional, not to mention an interpolated variable. Lots going on, easy mistake to make.

props BrianLayman.
fixes #32516.

#3 @nacin
10 years ago

In 32633:

Revert change to default-filters.php in [32632]. see #32516.

#4 @wonderboymusic
10 years ago

Sorry about that!

Note: See TracTickets for help on using tickets.