Context Navigation

← Previous Ticket
Next Ticket →

#32516 closed defect (bug) (fixed)

Revision 32599 Breaks menus & all other theme_mods_% stored values.

Reported by:	BrianLayman	Owned by:	nacin
Priority:	normal	Milestone:	4.3
Component:	General	Version:	4.3
Severity:	normal	Keywords:
Cc:		Focuses:

Description

Scott's most recent check-in synced into my VIP QuickStart install and I've spent the last 90 minutes trying to figure out what I broke. :D

He moved a return value up into an if statement inside get_theme_mods and it shouldn't be there. As a result, theme_locations is never returned on current dbs.

Diff/patch attached.

Attachments (1)

theme.php.diff (317 bytes ) - added by BrianLayman 11 years ago.: Patch to get menus et al working again…

Download all attachments as: .zip

Change History (5)

@BrianLayman
11 years ago

Attachment theme.php.diff added

Patch to get menus et al working again...

#1 @nacin
11 years ago

Milestone Awaiting Review → 4.3

#2 @nacin
11 years ago

Owner set to nacin
Resolution → fixed
Status new → closed

In 32632:

Fix return error in get_theme_mods() from [32629].

Split a line with both an assignment and a conditional, not to mention an interpolated variable. Lots going on, easy mistake to make.

props BrianLayman.
fixes #32516.

#3 @nacin
11 years ago

In 32633:

Revert change to default-filters.php in [32632]. see #32516.

#4 @wonderboymusic
11 years ago

Sorry about that!

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core