WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#32525 closed task (blessed) (fixed)

A link to the dashboard of a site is missing on the Network > Edit site page

Reported by: Fab1en Owned by: jeremyfelt
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.1
Component: Networks and Sites Keywords: ui-feedback has-patch
Focuses: ui, multisite Cc:

Description

On the Network > Sites page, a table lists all sites, and each line shows links to the dashboard and the front-end. But when one of those sites is edited, the only link that appear is a link to the front-end.

That would be very handy to also have a link to the dashboard on this page.

Attachments (17)

32525.patch (1.1 KB) - added by Fab1en 3 years ago.
Add a link to the dashboard in Network > Edit site page
32525.2.patch (4.1 KB) - added by Fab1en 3 years ago.
Add a link to the dashboard in Network > Edit site page for all tabs
32525_side.patch (3.8 KB) - added by Fab1en 3 years ago.
Dashboard link on the side
32525_tab.patch (4.4 KB) - added by Fab1en 3 years ago.
Dashboard link after the tabs
32525_under.patch (3.6 KB) - added by Fab1en 3 years ago.
Dashboard link under the site URL
32525_tab.2.patch (5.8 KB) - added by Fab1en 3 years ago.
Dashboard link after the tabs : use h2 to wrap tabs and an existing CSS class for the link
dashboard-mobile.png (64.4 KB) - added by jeremyfelt 3 years ago.
dashboard-medium.png (90.8 KB) - added by jeremyfelt 3 years ago.
dashboard-large.png (139.9 KB) - added by jeremyfelt 3 years ago.
32525.diff (5.0 KB) - added by jeremyfelt 3 years ago.
32525.2.diff (4.3 KB) - added by jeremyfelt 3 years ago.
after-32525.2.diff-large.png (172.8 KB) - added by jeremyfelt 3 years ago.
after-32525.2.diff-medium.png (146.6 KB) - added by jeremyfelt 3 years ago.
after-3255.2.diff-small.png (94.9 KB) - added by jeremyfelt 3 years ago.
32525.3.diff (4.7 KB) - added by jeremyfelt 3 years ago.
after-32525.3.diff-large.png (127.8 KB) - added by jeremyfelt 3 years ago.
after-32525.3.diff-small.png (89.1 KB) - added by jeremyfelt 3 years ago.

Download all attachments as: .zip

Change History (40)

@Fab1en
3 years ago

Add a link to the dashboard in Network > Edit site page

#1 @earnjam
3 years ago

  • Version changed from trunk to 3.1

#2 @earnjam
3 years ago

  • Keywords ui-feedback added

If this link is added this way, it should probably be added on site-users.php, site-themes.php and site-settings.php as well, as the header is hardcoded in each of those pages.

@Fab1en
3 years ago

Add a link to the dashboard in Network > Edit site page for all tabs

#3 @Fab1en
3 years ago

  • Keywords has-patch added

You are perfectly right @earnjam. I modified my patch to reflect this.

#4 @jeremyfelt
3 years ago

  • Milestone changed from Awaiting Review to 4.3

+1, I've been missing this. :)

We should grab screenshots of before/after for UI feedback.

There may be an opportunity in a separate ticket to handle the common header these 4 screens share.

#5 @jeremyfelt
3 years ago

I think we need to find a better place for the dashboard link. When it's added directly to the Edit Site <h2>, things seem cluttered and don't wrap well on mobile.

I'm tossing up a few screenshots to start brainstorming. They're all at a smaller size as that's when the wrap will matter. The first is current trunk, the second is from 32525.2.patch, and the third is another attempt with the dashboard link in an <h3> below the edit site text.

https://cldup.com/XPEWlvvLne.pnghttps://cldup.com/tgYjYpXuTR.pnghttps://cldup.com/HZv0AWptpM.png

Thoughts? Is it possible that a dashicon makes sense in all of this?

#6 @Fab1en
3 years ago

And why not putting it after the tab list ? https://cldup.com/LcH2XJS6zr.png

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

#8 @jeremyfelt
3 years ago

  • Owner set to jeremyfelt
  • Status changed from new to assigned
  • Type changed from enhancement to task (blessed)

I'd really like to see this in 4.3 and I don't think we're far from determining the correct placement. I'll take ownership of getting this through or punted in the next week.

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

@Fab1en
3 years ago

Dashboard link on the side

@Fab1en
3 years ago

Dashboard link after the tabs

@Fab1en
3 years ago

Dashboard link under the site URL

#10 @Fab1en
3 years ago

I have updated the patch and made three versions, corresponding to the three screenshots above :

  1. 32525_side.patch : link is on the side, after the site URL
  2. 32525_tab.patch : link is after the tabs
  3. 32525_under.patch : link is under the site URL

My personal preference goes to the "tab" version which is cleaner, more natural and takes less space.

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

#12 @Fab1en
3 years ago

@ryan has posted some screenshots on Make/Core that shows a new link in the Apparence / Menu page to manage menu directly in the customizer. This link appears just after the tabs, in a similar approach to the "tab" version of my patch.

https://make.wordpress.org/core/files/2015/06/Screen-Shot-2015-06-30-at-3.16.57-PM.png

I think we can follow that example for our "Dashboard" link. The only thing to change on the patch is the class used on the link.

@Fab1en
3 years ago

Dashboard link after the tabs : use h2 to wrap tabs and an existing CSS class for the link

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

@jeremyfelt
3 years ago

#14 @jeremyfelt
3 years ago

Thanks for continuing on this, @Fab1en. I like mirroring the pattern used in the menus screen here for the Customizer. I think having that button hanging out works.

It seems like both have the same issue on smaller layouts though. At a medium layout, the button gets a little larger and looks out of place. On mobile, it breaks completely.

Need to look for a related ticket for the Customizer to see if we can piggy-back onto those styles for a resolution.

I've updated your same patch in 32525.diff as I had some issues applying it cleanly to my SVN setup.

#15 @jeremyfelt
3 years ago

Briefly discussed this with @helen in Slack yesterday. Though it understandably appears so at first glance, this is probably not the pattern we should be using for this. Rather, we'll try to go with the text link next to the URL. I'm going to play around with some stuff right now.

@jeremyfelt
3 years ago

#16 @jeremyfelt
3 years ago

32525.2.diff goes with text links for "Visit" and "Dashboard" below the H1 title. It also changes that title from the URL to the name of the site instead. That's a little beyond the original scope of this ticket, but it feels right at the moment. We could also go with just "Dashboard" below the title and leave the URL as is.

Also noting that the links under the H1 element is one of the ideas @Fab1en provided earlier.

Previously, #17257.

Last edited 3 years ago by jeremyfelt (previous) (diff)

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

#18 @Fab1en
3 years ago

That one looks great ! I like the "Visit | Dashboard" pattern : it looks like the one found on the Network > Sites listing page.

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

@jeremyfelt
3 years ago

#20 @jeremyfelt
3 years ago

I removed the top margin of the "View | Dashboard" text in 32525.3.diff per feedback on spacing from @helen.

A couple questions:

  • Is common.css the correct place for these styles?
  • Is edit-site-actions good for the class name here?
  • Things looking good in general?

#21 @jeremyfelt
3 years ago

I'm digging the current version. Going to get this in to facilitate testing.

#22 @jeremyfelt
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33186:

Network Admin: Improved header information in Edit Site tabs.

  • Use the site's name rather than URL in the Edit Site header.
  • Provide "Visit" and "Dashboard" links for the site on all tabs.

Props @Fab1en, @jeremyfelt.
Fixes #32525.

This ticket was mentioned in Slack in #core-flow by boren. View the logs.


3 years ago

Note: See TracTickets for help on using tickets.