Password reset error - unwanted character in the link with some email service (they are parsing incorrectly) - make it more bulletproof

[sinusepsilon]

On my site some user wasn't able to reset password. I made an account at an email service which parsed the mails incorrectly. The problem seems to be that the mail ends with a link. It would be easy to end default wp mails with some text instead, so the link would be ok.

More details: ​https://wordpress.org/support/topic/password-reset-error-unwanted-character-in-the-link?replies=5#post-7026877

I hope this helps, thanks, sinusgamma.

[SergeyBiryukov]

Hi @sinusepsilon, welcome to Trac.

As noted in the forum thread, this appears to be a problem with the email service you're using.

See comment:2:ticket:23420 for a potential workaround.

Previously: #21095, #23420.

[cbutlerjr]

As noted in the forum thread, this appears to be a problem with the email service you're using.

@SergeyBiryukov - True, but as @sinusepsilon mentioned in the thread, it appears there is a possible solution by making the link not the end of the email. Does it seem reasonable to leave this open for a possible fix or should it be closed as wontfix?

[cbutlerjr]

Since the problem is on the email service side, this isn't really a bug - marking this as "enhancement"

[SergeyBiryukov]

Replying to cbutlerjr:

True, but as @sinusepsilon mentioned in the thread, it appears there is a possible solution by making the link not the end of the email.

The thread has an assumption that adding some text after the link would fix the issue for all problematic services:

So the problem is that the mail ends with a link. I think it would be easy for wordpress to send mails with some text after the link, so I suppose this could solve the problem with all the problematic mail services.

From my experience with this issue, most of the affected services are problematic in their own way: some treat the closing angle bracket as a part of the URL, some strip the link altogether, etc., and it doesn't matter whether the link is at the end of the email or not.

Wrapping URLs in angle brackets is recommended behaviour by both ​the W3C and in ​Section C of the URI RFC.

We could probably improve the situation in #23578 in case wp_mail_content_type is set to text/html by a plugin, but otherwise I don't think there's much we'll be able to do here.