Introduce filter for disabling new user notifcation

[jfarthing84]

We should introduce an action within register_new_user as a conditional to make it easy for plugins to disable the default new user notification.

[jfarthing84]

And by action, I meant filter, of course ;-)

[johnbillion]

wp_new_user_notification() is called in several places. A filter inside that function may be a better idea.

[jfarthing84]

In that case, the function is pluggable, so I could just override it. However, I've never been a fan of the unpredictability of pluggable functions. As we all know, it's very well possible that another plugin may override it first. So, with that said, here's a patch.

[jfarthing84]

Move the filter to wp_new_user_notification.

[jfarthing84]

Related #11210.

[darrenlambert]

I get an error when trying to apply the patch

error: pluggable.php: No such file or directory

Seems the file paths in the patch are incorrect?

wp-includes/pluggable.php should be src/wp-includes/pluggable.php

[DrewAPicture]

@darrenlambert: When testing patches from core trac, the recommended method is to leverage the patch module for grunt shipped with our build tools in the develop.svn.wordpress.org repo. It can handle the different directories problem. For more on that, see the ​Testing a Patch page in the Core Contributor Handbook.

If you'd still like to apply the patch directly, I'd suggest moving the the patch file into your src/ directory and applying from there.

[jfarthing84]

This was actually resolved a different way in [34251].

[johnbillion]

Duplicate of #33587.