Remove extra gravatar api call

[ravinderk]

get_avatar function is making two api call to fetch simple avatar and 2x avatar, we can save one extra api call by replacing s url query parameter by 2x size of current avatar size.

[ravinderk]

change under get_avatar function to remove extra api call

[johnbillion]

Thanks for the patch, ravinderk!

[SergeyBiryukov]

In 32702:

In get_avatar(), avoid a second get_avatar_data() call to get the 2x URL.

props ravinderk.
fixes #32572.

[iseulde]

This could affect plugins that rely on the size parameter. The link could have a very different structure.

[miqrogroove]

Agreeing with @iseulde here. The only way to avoid the second call is to restructure get_avatar_data() to return two or more URLs.

[miqrogroove]

Restore avatar filters broken by previous patch.

[miqrogroove]

New patch restores filtering of the 2x url and allows plugins to supply their own args, though slightly different from how it works in 4.2.

[ravinderk]

@johnbillion @SergeyBiryukov
Thank for appreciation :)

@iseulde
Can you elaborate more, how can my patch affect plugin?
$url2x used to get image for double size of current avatar size, it will be always 2x of current size. in my patch i calculated $url2x just after $url that means i always have latest $args.

[iseulde]

The URL may not have an s parameter as there are filters in place so that a plugin can return a URL with a completely different structure.

[ravinderk]

@iseulde
I did not understand, if url may not have s parameter then add_query_arg function will add 2x image size value to url and if it already exist then it will replace it with new 2x image size value.

Yes url can be different but it will be a gravatar api url in which s parameter is valid.

[miqrogroove]

Replying to ravinderk:

Yes url can be different but it will be a gravatar api url in which s parameter is valid.

That is an invalid assumption.

[ravinderk]

Replying to miqrogroove:

That is an invalid assumption.

Let take a case where gravatar api changes and s parameter is not valid, in that case we have to rewrite my patch and get_avatar_data() function because they are both using s parameter in there url params.

$url_args = array(
		's' => $args['size'],
		'd' => $args['default'],
		'f' => $args['force_default'] ? 'y' : false,
		'r' => $args['rating'],
	);

	$url = sprintf( 'http://%d.gravatar.com/avatar/%s', $gravatar_server, $email_hash );

	$url = add_query_arg(
		rawurlencode_deep( array_filter( $url_args ) ),
		set_url_scheme( $url, $args['scheme'] )
	);

[iseulde]

@ravinderk Take a look at ​https://developer.wordpress.org/reference/hooks/pre_get_avatar_data/.

[ravinderk]

@iseulde
Thank for link. I am creating a new patch maybe it will not break WordPress core.

[ravinderk]

Fix for breaking gravatar functionality on pre_get_avatar_data hook

[ravinderk]

Removing extra $url2x variable from patch

[ravinderk]

set $argsurl2x? to false if current comment type is not in list of allowed comment types

[ravinderk]

@johnbillion @iseulde @SergeyBiryukov
what do you think about my latest patch?

[nacin]

Is get_avatar_data() that slow?

[obenland]

@SergeyBiryukov, beta1 is one week away, can you get this resolved until then?

[nacin]

I don't see compelling data to do this. What's the performance difference? I'd suggest, pending any feedback, a revert of [32702] and a wontfix.

[miqrogroove]

I am also in favor of revert. Adding "2x" args filters may be beneficial some day, but the premise of this ticket is misguided.

[ravinderk]

@nacin

what happen if i want 2x image form my custom avatar.

1. add filter at pre_get_avatar and write some more custom functionality on this hook or,
2. add a filter at pre_get_avatar_data but i get only simple 1x images from it, because get_avatar_url return simple 1x url

Question

1. Is it good to call same function two time while we can get same thing in one call.
2. What is a best way to hanble 2x image for custom avatar?

[SergeyBiryukov]

In 32969:

Revert [32702]. The URL may not have an s parameter as there are filters in place so that a plugin can return a URL with a completely different structure.

see #32572.

[SergeyBiryukov]

get_avatar_data() does not make any external requests or complex calculations, so the performance difference should be negligible.

[rachelbaker]

#36315 was marked as a duplicate.