WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#32574 closed defect (bug) (fixed)

Compiled qunit tests should test minified files

Reported by: iseulde Owned by: iseulde
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

It should test the files as they are released. There's not much point in just testing a copy.

Attachments (2)

32574.patch (643 bytes) - added by iseulde 5 years ago.
32574.2.patch (699 bytes) - added by iseulde 5 years ago.

Download all attachments as: .zip

Change History (7)

@iseulde
5 years ago

#1 @iseulde
5 years ago

  • Keywords has-patch added

#2 @iseulde
5 years ago

Not sure why jquery doesn't have a .min suffix.

#3 @iseulde
5 years ago

This is also a problem for files that are only included minified such as TinyMCE. If I include the unminified version, compiled tests will fail. If I include the minified version it will fail to load plugins as there are no minified versions in trunk.

#4 @iseulde
5 years ago

  • Milestone changed from Awaiting Review to 4.3

Works well here. If there are problems we can find an alternative.

Last edited 5 years ago by iseulde (previous) (diff)

@iseulde
5 years ago

#5 @iseulde
5 years ago

  • Owner set to iseulde
  • Resolution set to fixed
  • Status changed from new to closed

In 32698:

QUnit: test minified files

Fixes #32574.

Note: See TracTickets for help on using tickets.