Opened 9 years ago
Closed 9 years ago
#32588 closed defect (bug) (fixed)
Preview window is reused even if the user navigates to another page
Reported by: | iseulde | Owned by: | |
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch |
Focuses: | Cc: |
Description
To reproduce, preview a post. The preview will be loaded in a new tab. Go to that tab and navigate to another page (same/different domain). Go back and preview the post again. The preview is loaded in the same tab, so now I lost that document. I would expect the preview to load in a new tab if the URL changed.
It's pretty weird when tabs I knew I had open suddenly disappear.
Attachments (1)
Change History (8)
#2
@
9 years ago
We probably can output some (inline) JS to remove the window.name on unload
, then add it back in the new page header. Will need to pass the name as query arg for this to work.
This seems a little bit hacky and will need testing in all possible browsers.
#3
@
9 years ago
- Keywords has-patch needs-testing added
32588.patch should do it. May need some review/improving.
#4
follow-up:
↓ 6
@
9 years ago
- Milestone changed from Awaiting Review to 4.3
Awesome, works well. Tested Chrome, FF, Safari and IE11, all work well. I also tested IE8 and it seems to break there. I get an AYS message. Without the patch it works.
And id
seems unused in the script.
#6
in reply to:
↑ 4
@
9 years ago
Replying to iseulde:
Actually this won't work in IE8 no matter what :)
Removed support for IE8. Seems to work well in all other common browsers, including emulated IE9 and 10. Leaving open in case there are any problems in (native) IE9 and/or other "exotic" browsers.
Related: #20233, #32278 (which could use a response).