Make the text of the Image delete AYS dialog clearer

[lastnode]

When you delete Images from the Media Library, the warning dialog currently reads:

"You are about to permanently delete the selected items."

This text could be a little clearer, and indicate that, once deleted:

• Attached Images will not be visible in any Posts or Pages they are attached to.

• Both Attached and Unattached Images will not be available online at all.

[ryan]

AYS dialog when deleting media.

[ryan]

Images are not always reliably attached. Notably, images uploaded directly to the media lib and later published don't attach. We could name specific posts when attachment is known and fallback to generic language otherwise.

Related AYS work. https://core.trac.wordpress.org/ticket/28566

All of our AYS dialogs need to be friendlier.

[tellyworth]

Replying to ryan:

Images are not always reliably attached. Notably, images uploaded directly to the media lib and later published don't attach.

Should improving this be part of the solution? I know there's been some discussion about the limitations of this in the past, for example on #23041.

Totally agree that it makes sense to provide a more specific warning to the user in cases where the attachment status is known.

[ryan]

Images are not always reliably attached. Notably, images uploaded directly to the media lib and later published don't attach.

Should improving this be part of the solution? I know there's been some discussion about the limitations of this in the past, for example on #23041.

The gallery shortcode now lists IDs rather than relying on attachment status. We're becoming less dependent on attachment status and should probably introduce API for getting all images associated with a post regardless of attachment status. This would assist Reader interfaces likes those in the apps and on wordpress.com, which currently have troubles finding all of a post's images. This would also help the "Uploaded to this post" dropdown in the media modal. That wouldn't help this case, however, since we can't go peeking content for every post looking to see which references the image in question.

Maybe it's worth automatically attaching unattached posts once inserted via the media modal. That's make lookup possible for the situation in this ticket. But, maybe that time is better spent on API for finding images in post content.

[swissspidy]

See also #39712.