About: all admin notices should be hidden

[jadpm]

Related to #26519, some admin notices are not being hidden on the About page. That ticket ensured that div.updated, div.error admin notices are hidden, but we also have other classnames like notice-warning and notice-info which were not included.

Also, we should think on normalizing the classnames for admin notices:

• div.update equals .notice-success
• div.error equals .notice-error
• .notice-warning and .notice-info do not have a matching pair.

[jadpm]

about.css diff

[johnbillion]

Culprit: #27418

[obenland]

How can I reproduce the notices showing?
Shouldn't it be enough to add .about-wrap .notice to cover all new cases?

[jadpm]

Yes, .about-wrap .notice should produce the same effect and it would also be much more similar to the styling we already have in common.css where we define styling for .wrap .notice, .wrap div.updated, .wrap div.error on the same place. I'm updating the patch to apply this solution better.

It is easy to get an admin notice on the About page:

add_action( 'admin_notices', 'ek_display_admin_notices' );
function ek_display_admin_notices() {
	echo '<div id="ek-admin-notice" class="notice notice-warning">';
	echo 'Whatever';
	echo "</div>";
}

[jadpm]

Patch updated

[obenland]

In 33113:

Hide notices introduced in [30505] on about page.

See #19237.

Props jadpm.
Fixes #32625.