WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#32633 closed enhancement (fixed)

Allow the sortable items selector in wpNavMenu to be overridden

Reported by: westonruter Owned by: ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch
Focuses: javascript Cc:

Description

For Menu Customizer (#32576) we are trying to re-use as much of nav-menu.js as possible. However, there is a problem in wpNavMenu uses an overly-generic selector > * for the sortable items. We need to allow this to be overriddable in the Customizer to be .customize-control-nav_menu_item, but nav-menu.js doesn't currently expose the selector via its options property. This needs to change.

Attachments (1)

32633.diff (2.3 KB) - added by westonruter 4 years ago.
Source (props adamsilverstein): https://github.com/xwp/wordpress-develop/commit/0f89312d238aa7ef80316d6d77633eaacf1e243f

Download all attachments as: .zip

Change History (2)

#1 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 32745:

Nav menu: Allow the sortable items selector in wpNavMenu to be overridden.

props adamsilverstein.
fixes #32633.

Note: See TracTickets for help on using tickets.