WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#32644 closed defect (bug) (fixed)

Multisite new user username field auto-capitalizes on mobile devices

Reported by: brad2dabone Owned by: jeremyfelt
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.0
Component: Users Keywords: has-patch
Focuses: ui, administration, multisite Cc:

Description

When adding a new user in the multisite network admin panel on an iOS device, the username auto-capitalizes, which is not ideal.

Attachments (3)

32644.diff (671 bytes) - added by brad2dabone 3 years ago.
32644-r1.diff (672 bytes) - added by brad2dabone 3 years ago.
user-new.diff (908 bytes) - added by sunnyratilal 3 years ago.
Update input attributes for wp-admin/user-new.php

Download all attachments as: .zip

Change History (16)

@brad2dabone
3 years ago

#1 @brad2dabone
3 years ago

Added autocapitalize="off" autocorrect="off" attributes in 32644.diff.

@brad2dabone
3 years ago

#2 @brad2dabone
3 years ago

autocapitalize="off" is deprecated. Replaced with autocapitalize="none".

#3 @helen
3 years ago

  • Milestone changed from Awaiting Review to 4.3

Nice! Are there other spots that could use this same treatment? I imagine all of the add user forms have the same problem. Happy to fix this one on its own, just want to chase down this road a little bit while we're here :)

#4 @earnjam
3 years ago

Another instance: #32646

This ticket was mentioned in Slack in #core-multisite by earnjam. View the logs.


3 years ago

#6 @jeremyfelt
3 years ago

  • Keywords has-patch added
  • Type changed from enhancement to defect (bug)

We should treat this one as a bug rather than enhancement.

#7 @jeremyfelt
3 years ago

This is a great start, @brad2dabone, thanks!

I think we can probably take care of both wp-admin/user-new.php and wp-admin/network/user-new.php in this ticket. It looks like iOS already handles email inputs fine, so just the user login inputs will need to be patched.

#8 @jeremyfelt
3 years ago

  • Owner set to jeremyfelt
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


3 years ago

@sunnyratilal
3 years ago

Update input attributes for wp-admin/user-new.php

#11 @jeremyfelt
3 years ago

Thanks for the wp-admin/user-new.php patch, @sunnyratilal! A note for the future - no notification is sent after uploading a patch, even if you describe it. It's good to leave a follow up comment immediately after so that a notification is sent out.

Things look good on both of these.

#12 @jeremyfelt
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33160:

Set autocapitalize to none, autocorrect to off for new username inputs on iOS.

This corrects both the standard wp-admin new user form and the network new user form.

Props @brad2dabone, @sunnnyratilal.
Fixes #32644.

#13 @christinecooper
2 years ago

Wait a minute, are you telling me that there are 2 other tickets with this issue, and this is yet to be implemented to core?

Who's making decisions nowadays?

Note: See TracTickets for help on using tickets.