Save Changes button should not show on my-sites.php when user is only member of one site

[jmacaluso711]

In my sites there is a select box to change your primary site even if you only have one site. It doesn't make any sense to have the select if you only have one site.

[earnjam]

Screenshot

[earnjam]

The main issue seems to be the appearance of the "Save Changes" button when there are no changes that can even be made. The select box just renders as text.

Perhaps we should conditionally show the button (or the entire form) only when you are a member of more than one site.

[jeremyfelt]

Good call @jmacaluso711, thanks for the ticket!

[Oxymoron]

Removes Save Changes button when there is only 1 site

[Oxymoron]

Attached a patch that removes the 'Save Changes' button when the user only has 1 site (meaning they have nothing to update or save).

[earnjam]

Only problem I see here is that there is a filter on this page for adding additional input fields for the whole form or each site on the list, which is also why the save changes button appears at the bottom instead of the top.

[obenland]

Shows button if user has one site and no extra settings are added.

[obenland]

@jeremyfelt: Your turn. :)

[jeremyfelt]

32645.2.diff also places the nonce and action inputs in the conditional output.

We don't use has_filter much in core, but the use case here makes sense.

[jeremyfelt]

In 33080:

Only output Save Changes in My Sites when a user is a member of more than one site.

The conditional also checks for the existence of filters that may otherwise alter the HTML in My Sites to include extra form inputs for these users. If a filter is in use, the Save Changes button will display.

Props @Oxymoron, @obenland.
Fixes #32645.