Multisite UX - Move Save Changes button to be next to the Primary Site select field

[kdamken]

On the My Sites page, there is a select field that lets you choose your primary site. Below that is a table that lists out your sites, then below that there is the button to Save Changes for when you select a new primary site. Since the Save Changes button is related to the select dropdown and not the table, it might be better to have the button to the right of the select field rather than underneath the table.

[earnjam]

Could be done in coordination with #32645

[amcreative]

32647.diff

[amcreative]

screenshot of changes

[amcreative]

@earnjam

I've attached a diff that moves the button from the current location to the right of the select box. I've also attached a screenshot showing the change.

[jeremyfelt]

Thanks for the ticket @kdamken! This makes a lot of sense, the placement of the Save Changes button on this screen has confused me plenty of times. :)

[kdamken]

Thanks @jeremyfelt! Though I can't take too much credit, it was @earnjam who had the idea and showed me how to add a ticket to Trac at the Philly Wordcamp.

[earnjam]

In today's example of "nothing is ever simple in multisite", upon digging on this a bit more, I discovered that the Save Changes button is at the bottom because the sites list has the myblogs_options filter, which in theory would allow plugins to add additional fields for submitting/processing. It defaults to an empty string, but could be used to insert extra inputs into this form.

My original thought on this ticket was to simply shorten the <form> to only include the Primary Site select, but that would break any usage of this filter that adds inputs.

The other option is to do as @amcreative did and simply move the save button to the top. That would not break usage of the filter, but it would make it less ideal if you had a long list of sites and made a change at the bottom and had to scroll back up.

I'm not sure how much that filter is actually used in the wild, but I'm hesitant to change it without some understanding.

[amcreative]

@earnjam Would it make sense to have the button at both the top and bottom as we see in other instances throughout WordPress such as "Bulk Actions" in the post editor? This would provide some context to the drop down at the top of the "My Sites" screen but would also not lose the option if the list is long.

[obenland]

Replying to earnjam:

In today's example of "nothing is ever simple in multisite", upon digging on this a bit more, I discovered that the Save Changes button is at the bottom because the sites list has the myblogs_options filter, which in theory would allow plugins to add additional fields for submitting/processing. It defaults to an empty string, but could be used to insert extra inputs into this form.

Yes, we should probably leave the button where it is now.

[jeremyfelt]

Agreed, our hands are pretty tied here at the moment.

I'll echo Boone from #31685:

The more I look at My Sites, the sadder I get - it could probably use a significant rethink to make it something much more beautiful and useful.

It's going to take an overhaul (replacement?) of this screen to make changes like the one in this ticket. Going to close this and the related #32645 as maybelater, because maybe later. :)

[jeremyfelt]

Actually, #32645 still has a chance due to craftiness.