![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 11 years ago
Closed 11 years ago
#32657 closed defect (bug) (fixed)
Media List (wp-list-table): attachment thumbnails overlap each other
| Reported by: | tyxla | Owned by: | helen |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.3 |
| Component: | Administration | Version: | 4.3 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | ui |
Description
When viewing the Media Library in list view, the thumbnails overlap the next entry.
Attaching a preview of the issue.
Attachments (4)
Change History (14)
#1
@
11 years ago
Since the thumbnail container is absolute, I suggest that we fix this by adding a min height of the .media-info. This will work fine for both cases - image thumbnails (which are 60px in height), and icon thumbnails (which are 64px in height).
Patch coming in a minute.
@
11 years ago
Adding min height to .media-info to resolve the issue with overlapping thumbnails in media list view.
#3
@
11 years ago
- Milestone Awaiting Review → 4.3
Possibly a result from recent Admin UI work.
/cc @helen @stephdau
#4
@
11 years ago
Similar/related to https://core.trac.wordpress.org/ticket/32395#comment:10
#5
@
11 years ago
Looks like row actions are missing :) Going to dig into that first, though we should probably do this anyway just in case.
#7
@
11 years ago
Adding the min-height would make each row taller for not much reason given the default state, though I do wonder if we should protect against this. Thoughts?
#8
@
11 years ago
Oh well. How could I have missed that the row actions are missing. :) Thanks for noticing that.
But with the latest commit [32798] I have some PHP notices appearing there. Turns out that they are because of bad parameter naming for handle_row_actions(). I've attached a patch that addresses these, and updated the method docs as well.
Also, I've updated the CSS for consistency with that solution. With this approach, min-height will not be necessary anymore.
Attaching a preview of the issue