Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#32657 closed defect (bug) (fixed)

Media List (wp-list-table): attachment thumbnails overlap each other

Reported by: tyxla's profile tyxla Owned by: helen's profile helen
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch
Focuses: ui Cc:

Description

When viewing the Media Library in list view, the thumbnails overlap the next entry.

Attaching a preview of the issue.

Attachments (4)

32657.jpg (140.5 KB) - added by tyxla 10 years ago.
Attaching a preview of the issue
32657.patch (459 bytes) - added by tyxla 10 years ago.
Adding min height to .media-info to resolve the issue with overlapping thumbnails in media list view.
32657-after.jpg (144.4 KB) - added by tyxla 10 years ago.
Here is a preview of the fixed issue.
32657.2.patch (1.4 KB) - added by tyxla 10 years ago.
Updating @helen's version to fix a couple of minor issues and update the CSS.

Download all attachments as: .zip

Change History (14)

@tyxla
10 years ago

Attaching a preview of the issue

#1 @tyxla
10 years ago

Since the thumbnail container is absolute, I suggest that we fix this by adding a min height of the .media-info. This will work fine for both cases - image thumbnails (which are 60px in height), and icon thumbnails (which are 64px in height).

Patch coming in a minute.

@tyxla
10 years ago

Adding min height to .media-info to resolve the issue with overlapping thumbnails in media list view.

@tyxla
10 years ago

Here is a preview of the fixed issue.

#2 @tyxla
10 years ago

  • Keywords has-patch added

#3 @obenland
10 years ago

  • Milestone changed from Awaiting Review to 4.3

Possibly a result from recent Admin UI work.

/cc @helen @stephdau

#5 @helen
10 years ago

Looks like row actions are missing :) Going to dig into that first, though we should probably do this anyway just in case.

#6 @helen
10 years ago

In 32798:

Media list table: Restore row actions.

see #29881, #32657.

#7 @helen
10 years ago

Adding the min-height would make each row taller for not much reason given the default state, though I do wonder if we should protect against this. Thoughts?

@tyxla
10 years ago

Updating @helen's version to fix a couple of minor issues and update the CSS.

#8 @tyxla
10 years ago

Oh well. How could I have missed that the row actions are missing. :) Thanks for noticing that.

But with the latest commit [32798] I have some PHP notices appearing there. Turns out that they are because of bad parameter naming for handle_row_actions(). I've attached a patch that addresses these, and updated the method docs as well.

Also, I've updated the CSS for consistency with that solution.

Version 0, edited 10 years ago by tyxla (next)

This ticket was mentioned in Slack in #core by tyxla. View the logs.


10 years ago

#10 @helen
10 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 32805:

Media list table: Avoid PHP notices by using the proper variables.

Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.

Note: See TracTickets for help on using tickets.