WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#32668 closed enhancement (fixed)

Give option to install parent theme if missing

Reported by: rabmalin Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Themes Keywords: ux-feedback has-patch has-screenshots commit
Focuses: ui, administration Cc:
PR Number:

Description

When child theme is installed, that theme goes under Broken Themes if parent theme is missing. It would be great to have button to install parent theme (if exists in repo).

Attachments (8)

screenshot1.png (18.5 KB) - added by rabmalin 4 years ago.
32668-1.diff (1.5 KB) - added by rabmalin 4 years ago.
32668.diff (1.5 KB) - added by rabmalin 4 years ago.
screenshot-for-patch.png (20.9 KB) - added by rabmalin 4 years ago.
32668.2.diff (1.6 KB) - added by SergeyBiryukov 4 years ago.
32668.2.png (10.2 KB) - added by SergeyBiryukov 4 years ago.
32668.3.diff (1.5 KB) - added by SergeyBiryukov 4 years ago.
32668.3.png (11.2 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (31)

@rabmalin
4 years ago

#1 @philiparthurmoore
4 years ago

This is a fantastic idea.

#2 @johnbillion
4 years ago

  • Keywords needs-patch ux-feedback added
  • Version trunk deleted

#3 follow-up: @swissspidy
4 years ago

Of course this only works for themes on WordPress.org. How can we check for them?

#4 @rabmalin
4 years ago

I dont know the detail how WordPress.org API works. But may be we could use same approach how currently themes get update data from .org.

#5 in reply to: ↑ 3 @obenland
4 years ago

Replying to swissspidy:

Of course this only works for themes on WordPress.org. How can we check for them?

See the Codex for some high level info: https://codex.wordpress.org/WordPress.org_API#Themes

@rabmalin
4 years ago

#6 @rabmalin
4 years ago

  • Keywords has-patch dev-feedback 2nd-opinion added; needs-patch removed

Patch added.

#7 @wonderboymusic
4 years ago

  • Milestone changed from Awaiting Review to 4.4

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 years ago

#9 @SergeyBiryukov
4 years ago

  • Keywords needs-screenshots added; dev-feedback 2nd-opinion removed

#10 @helen
4 years ago

  • Keywords dev-feedback 2nd-opinion added; needs-screenshots removed

Sergey beat me to the keyword, but could we get a screenshot please? The original screenshot tells me that this is kind of ugly right now and we should probably do a little tweaking for that here :)

#11 @SergeyBiryukov
4 years ago

  • Keywords needs-screenshots added; dev-feedback 2nd-opinion removed

#blametrac

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 years ago

#13 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#14 follow-up: @rabmalin
4 years ago

I just noticed needs-screenshots keyword. Does that mean I need to make screenshot of the patch?

#15 in reply to: ↑ 14 @swissspidy
4 years ago

Replying to rabmalin:

I just noticed needs-screenshots keyword. Does that mean I need to make screenshot of the patch?

Yes. See Helen's comment from above:

Sergey beat me to the keyword, but could we get a screenshot please? The original screenshot tells me that this is kind of ugly right now and we should probably do a little tweaking for that here :)

@rabmalin
4 years ago

#16 @rabmalin
4 years ago

Screenshot added.

#17 @DrewAPicture
4 years ago

  • Keywords has-screenshots added; needs-screenshots removed

#18 @SergeyBiryukov
4 years ago

  • Keywords commit added

32668.2.diff moves the button to its own column, see 32668.2.png.

#19 follow-up: @obenland
4 years ago

Have you considered top-aligning the button and the Delete link with the rest of the text?

Last edited 4 years ago by obenland (previous) (diff)

#20 @SergeyBiryukov
4 years ago

32668.3.diff displays the button for themes that are actually missing a parent, see 32668.3.png.

Also swaps delete and install columns, otherwise the Delete link ends up in different columns for different themes.

#21 in reply to: ↑ 19 @SergeyBiryukov
4 years ago

Replying to obenland:

Have you considered top-aligning the button and the Delete link with the rest of the text?

They look aligned to me :) It's just that those columns don't have a header.

#22 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35187:

Themes: Add Install Parent Theme button for child themes that are missing a parent theme.

Props rabmalin for initial patch.
Fixes #32668.

#23 @rabmalin
4 years ago

Great. Thanks for merging it to core. :)

Note: See TracTickets for help on using tickets.