Menu names in customizer shows HTML entities

[markoheijnen]

Currently when "Menus" is translated with entities like ' for Dutch "Menu's" then it's not correctly parsed due to the usage of {{menu.title}}. When this is menu.title then the value is displayed correctly.

I only fixed it for menus but I saw other places with only 2 brackets too. Unsure when to use what.

[ocean90]

{{}} is needed for escaping. We probably missed an instance of html_entity_decode().

[markoheijnen]

Looking over the code, I do see places where it's placed but it doesn't work. It still could placed when WP_Customize_Nav_Menus_Panel get's created but the title of WP_Customize_Nav_Menu_Section already get's it but still fails to parse correctly.

[markoheijnen]

The following code does work. I placed it inside WP_Customize_Panel->json();

$array['title'] = $output = preg_replace_callback("/(&#[0-9]+;)/", function($m) { return mb_convert_encoding($m[1], "UTF-8", "HTML-ENTITIES"); }, $array['title']);

[ocean90]

html_entity_decode()

[ocean90]

Related: #30737, #29572

32670.patch​ adds html_entity_decode() to section/panel titles.

[markoheijnen]

Works for me.

[ocean90]

In 32822:

Customizer: Decode HTML entities of panel/section titles.

Titles are now passed into Underscore templates but HTML-escaped, see #30737.

fixes #32670.