Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#32671 closed enhancement (invalid)

Make Menus link in admin bar go to Customizer

Reported by: voldemortensen's profile voldemortensen Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Customize Keywords: good-first-bug
Focuses: Cc:

Description

This needs to be consistent with other links in the admin bar.

 	if ( current_theme_supports( 'menus' ) || current_theme_supports( 'widgets' ) )
		$wp_admin_bar->add_menu( array(
			'parent' => 'appearance',
			'id'     => 'menus',
			'title'  => __( 'Menus' ),
			'href'   => admin_url( 'nav-menus.php' ),
			'meta'   => array(
				'class' => 'hide-if-customize',
			),
		) );

		if( current_user_can( 'customize' ) ) {
			$wp_admin_bar->add_menu( array(
				'parent' => 'appearance',
				'id'     => 'menus',
				'title'  => __('Menus'),
				'href'   => add_query_arg( urlencode( 'autofocus[panel]'), 'nav_menus', $customize_url ),
				'meta'   => array(
					'class' => 'hide-if-no-customize',
				),
			) );
		}

Change History (6)

#1 @helen
8 years ago

I am a bit hesitant about doing this and have actually been thinking about undoing the widgets link change from 4.2, as the load can be VERY slow and the need to wait for the panel to be loaded before it slides in adds to the feeling of waiting. It may not necessarily be any slower than going to the admin page, but the perception definitely is.

This ticket was mentioned in Slack in #core by helen. View the logs.


8 years ago

#3 @DrewAPicture
8 years ago

I was actually about to create a ticket to propose undoing the widgets and themes link changes in the Toolbar drop-down since we know that those screens are going to remain and be maintained in the near future.

I think as we've seen in community feedback, it creates an unexpected experience – if I want to go to the Customizer to use those enhanced interface, I'd click on the Customize link.

So I'm obviously -1 on this idea.

#4 @helen
8 years ago

The Slack link above in 2 is an impromptu discussion about a wider view of the toolbar content as well as the admin menu. The brief version is that beyond the concerns of speed, it's confusing that different links in the same menu lead to different contexts, especially without any warning. I think that's perhaps more the problem, even. I have suggested a separate top-level customize menu on the front end toolbar, unsure what should be done when in the context of the admin.

This ticket was mentioned in Slack in #core by helen. View the logs.


8 years ago

#6 @voldemortensen
8 years ago

  • Milestone 4.3 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing in favor of #32678

Note: See TracTickets for help on using tickets.