WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 9 of Ticket #32672


Ignore:
Timestamp:
06/28/2015 11:43:32 AM (10 years ago)
Author:
stevenkword
Comment:

Replying to designsimply:

I also tested 32672.2.diff, but I spotted an error in the console and the first menu gets listed twice in the Menu Locations panel if you follow the testing steps exactly and click Save & Publish before going to Menu Locations (​screenshot).

@gabrielperezs and I took a look at this during WCEU's contributor day. Both patches apply without issue, but introduce a new bug with the Menu Locations.

We were not able to reproduce the duplicate menus in the Locations Panel, but we are noticing that the newly created menus will not appear in the Locations Panel, without a Save & Publish action. Otherwise, the menu remains empty.

Steps to reproduce.

1.) Apply 32672.2.diff​ 2.) Add a new menu via the Customizer's Menu Panel. 3.) Select a menu location from the Menu Panel. 4.) Without saving, navigate to the Menu Locations Panel.

The newly created menu will not appear, presumably because the newly created menu is never saved.

We are only seeing this behavior in twentyfifteen and twentyeleven.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32672

    • Property Owner set to westonruter
    • Property Status changed from new to assigned
    • Property Keywords has-patch needs-testing added
    • Property Milestone changed from Awaiting Review to 4.3

  • Ticket #32672 – Description

    initial v9  
    1 * On a fresh install go to Appearance / Customizer / Menus
    2 * Add a menu and add some items, Save & Publish.
    3 * In Menu locations check your menu, Save & Publish.
     1Replying to [comment:8 designsimply]:
     2> I also tested 32672.2.diff, but I spotted an error in the console and the first menu gets listed twice in the Menu Locations panel if you follow the testing steps exactly and click Save & Publish before going to Menu Locations ([https://cldup.com/TsZhos4SHn.png screenshot]).
    43
    5 I recorded a video here: https://vimeo.com/130993994
     4@gabrielperezs and I took a look at this during WCEU's contributor day.  Both patches apply without issue, but introduce a new bug with the Menu Locations.
     5
     6We were not able to reproduce the duplicate menus in the Locations Panel, but we are noticing that the newly created menus will not appear in the Locations Panel, without a Save & Publish action.  Otherwise, the menu remains empty.
     7
     8Steps to reproduce.
     9
     101.) Apply [attachment: 32672.2.diff]
     112.) Add a new menu via the Customizer's Menu Panel.
     123.) Select a menu location from the Menu Panel.
     134.) Without saving, navigate to the Menu Locations Panel.
     14
     15The newly created menu will not appear.  This is presumably because the newly created menu is never saved.