Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#32675 closed defect (bug) (fixed)

Customizer Menus: "quick delete" X icon wrong position in IE8

Reported by: afercia's profile afercia Owned by: valendesigns's profile valendesigns
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch needs-testing
Focuses: ui Cc:

Description

See screenshot below. Had a quick look at all the several buttons with dashicons, they probably could be all standardized in just one generic rule with a few adjustments for special cases.
Worth considering that all browsers natively center text (hence dashicons too) inside buttons so the CSS could be greatly simplified.

https://cldup.com/eom71RLBru.png

Attachments (2)

32675.diff (402 bytes) - added by valendesigns 11 years ago.
IE8-fixed.png (36.3 KB) - added by valendesigns 11 years ago.

Download all attachments as: .zip

Change History (10)

#1 @afercia
11 years ago

  • Milestone changed from Awaiting Review to 4.3

#2 @afercia
11 years ago

  • Keywords needs-patch added; has-patch removed

#3 @designsimply
11 years ago

  • Summary changed from Menu Customizer: "quick delete" X icon wrong position in IE8 to Customizer Menus: "quick delete" X icon wrong position in IE8

#4 @valendesigns
11 years ago

  • Owner set to valendesigns
  • Status changed from new to assigned

@valendesigns
11 years ago

#5 @valendesigns
11 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

It's very difficult for me to test in IE8, because I keep getting script not responding errors and have to wait minutes each time I load the Customizer. I can't spend anymore time than I already have on this. Patch 32675.diff fixes the issue and if I had more patients for IE8 I would attempt to discover a better solution, but this fixes it for now.

#6 @celloexpressions
11 years ago

Works for me. I honestly don't care about IE8 at all here, if it takes hacks to make it look okay, that's what it takes.

This ticket was mentioned in Slack in #core by obenland. View the logs.


11 years ago

#8 @obenland
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32987:

Customizer: Correct position for menu item delete icon in IE8.

Props valendesigns.
Fixes #32675.

Note: See TracTickets for help on using tickets.