WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#32682 closed defect (bug) (fixed)

Customizer Menus:Improve accessibility of Add Menu Items button

Reported by: ocean90's profile ocean90 Owned by: ocean90's profile ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch
Focuses: accessibility Cc:

Description

From ​https://github.com/voldemortensen/menu-customizer/issues/87

The "Add Links" button, besides an aria-expanded attribute, would need also an aria-controls attribute. When the controlled panel is not immediately following the button and is very far in the source It's generally recommended to use aria-controls. For example:

<button type="button" class="button-secondary add-new-menu-item" aria-expanded="false" aria-controls="available-menu-items">Add Links</button>

Attachments (1)

32682.patch​ (2.4 KB) - added by ocean90 9 years ago.

Download all attachments as: .zip

Change History (3)

@ocean90
9 years ago

#1 @ocean90
9 years ago

  • Summary changed from Customizer Menus: Improve accessibility of Add Links button to Customizer Menus:Improve accessibility of Add Menu Items button

#2 @ocean90
9 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 32848:

Customizer: Improve accessibility of Add Menu Items button and its panel.

props afercia, ocean90.
fixes #32682.

Note: See TracTickets for help on using tickets.