WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#32689 closed enhancement (maybelater)

Customizer Menus: turn checkbox back to a plus sign if an item is added and deleted in the same session

Reported by: designsimply Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: 2nd-opinion
Focuses: ui Cc:

Description

When you add a menu item, the + icon becomes a checkbox icon as soon as the menu item is added, but that checkbox does not turn back into a plus sign symbol if the item is then removed via quick-delete. Should it?

https://cloud.githubusercontent.com/assets/1119271/8168865/e4381f88-1373-11e5-8c31-6bda930c52a2.png

Example screencast: 22s
Tested with WordPress 4.3-alpha-32784 and Menu Customizer plugin 0.6-20150615 on Firefox 38.0.5 on Mac OSX 10.10.3.

/hat tip for the original report from Anthony Hortin at https://wordpress.org/support/topic/confusing-label-on-added-menu-items?replies=2

Moved from https://github.com/voldemortensen/menu-customizer/issues/117

Change History (10)

#1 @johnbillion
6 years ago

#32690 was marked as a duplicate.

#2 @celloexpressions
6 years ago

  • Focuses ui added
  • Version set to trunk

I'd probably say this is a wontfix. Items can be added and removed multiple times, so once it's added there isn't a 1-1 relationship between the added item and the checked available item. The check is primarily there to give you visual indication that tapping the button was successful, particularly on mobile where you can't see the actual item get added. That being said, it wouldn't be hard to remove these whenever an instance of it is removed from the menu, it just won't always match directly.

#3 @designsimply
6 years ago

@celloexpressions, do you think it's worth making this change even if it just affects the same session? I don't remember it coming up in user testing, but it has come up a few times in WP community feedback. I think it would make the current session more clear even if it's not a 1-1 relationship that always matches directly later. I think what people are commenting on is the immediate flow they're in.

Since it is only speculation and hasn't come up in testing, I think it would be fine to wontfix now and re-open later if it keeps coming up.

#4 @celloexpressions
6 years ago

It can't even be 1:1 on the current session, since you could accidentally double-add something, then after deleting one it would go back to plus and still have one added to the menu. Doesn't mean we couldn't do it, but not sue that it would help much.

#5 @celloexpressions
6 years ago

We're running out of time to look at a solution here. Any one else have thoughts or ideas on this?

#6 @celloexpressions
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Going to close this for now - unfortunately the way this works doesn't really lend itself to being able to go back from an item that's in the menu to a corresponding object in the available items panel. The checkmark is primarily there because there were issues with being able to tell that clicking/tapping actually added the item, especially on mobile, but it's not really a comprehensive solution beyond a basic visual indicator that you tapped the item recently. This could definitely be improved on in the future.

If someone is able to figure out a way that we could accomplish this, please feel free to reopen.

#7 @valendesigns
6 years ago

Why don't we just fade back to normal? Seems easy and simple without worrying about doing a legitimate state reversal. I could create a patch that simply adds a class and removes it after x seconds which transition the icon back to normal smoothly with CSS. We don't need to over engineer something this trivial.

#8 @valendesigns
6 years ago

Another simple solution would be to add a unique but targetable class based on the object ID to both the source and destination and remove them during the deletion process which would trigger a transition on the source. Then we would not be arbitrarily removing state after x amount of seconds.

#9 @valendesigns
6 years ago

To solve the double item situation where you add it twice and remove one, only remove the source class when there aren't any other destination siblings that share that class.

#10 @tywayne
6 years ago

#33018 was marked as a duplicate.

Note: See TracTickets for help on using tickets.