Opened 10 years ago
Closed 10 years ago
#32706 closed task (blessed) (fixed)
Press This: Enable HTML Editor
Reported by: | kraftbj | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Press This | Keywords: | |
Focuses: | Cc: |
Description
"Old" Press This allowed you to switch between the Visual/Text TinyMCE editors. Ticket to track adding it to 4.2-era PT.
Needs:
- Re-enable quicktags when setting up editor.
- JS love to have the media picker and "Standard Editor" transition work.
- CSS love for text mode toolbar to appear and for the switcher to not overlap with the flyout.
Attachments (5)
Change History (21)
#1
@
10 years ago
32706.patch enables the quicktabs picker between the editor (explicitly, although the default is on) and adds CSS to ensure the buttons are visible. It uses the default icons at this time.
Needs JS love and how to fix the quicktabs appearing over the flyout panel on smaller screens. I couldn't figure out how to move it under without breaking the functionality of the quicktags (seen in https://cloudup.com/cgykphCKPOR )
#2
@
10 years ago
- Milestone changed from Awaiting Review to 4.3
In 32706.1.patch:
- Add support for the Text editor in PT, incl. inserting images/videos, etc.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
Still needs styling of the Visual | Text tabs and perhaps the Quicktags buttons.
#3
@
10 years ago
32706.1.patch is working very well in Chrome/Linux and Chrome/Android,including in "Disable the visual editor when writing" mode.
#4
@
10 years ago
The "Save Draft" transition from "Standard Editor" back to "Save Draft" isn't firing in the text editor mode.
@
10 years ago
32706.1 applied on a thinner browser window with the tag/cat nav open revealing outstanding CSS problem.
#10
follow-ups:
↓ 11
↓ 14
@
10 years ago
Leaving this open as the Visual and Text buttons may need a bit more styling.
#11
in reply to:
↑ 10
@
10 years ago
Replying to azaozz:
Uh, also forgot to add props kraftbj for the initial patch, sry.
I just need to find something else on PT to patch and get double-props. ;-)
This ticket was mentioned in Slack in #core by obenland. View the logs.
10 years ago
#13
@
10 years ago
- Keywords needs-patch added
- Owner set to azaozz
- Status changed from new to assigned
- Type changed from enhancement to task (blessed)
#14
in reply to:
↑ 10
;
follow-up:
↓ 15
@
10 years ago
- Keywords needs-patch removed
Replying to azaozz:
Leaving this open as the Visual and Text buttons may need a bit more styling.
Do they need more styling or can we close the ticket?
Initial patch enabling the editor picker