Plugin title / description / etc. parsing error

[Viper007Bond]

A client sent me this plugin. I have no f'ing clue why it shows up so horribly wrong in /wp-admin/plugins.php, but we should account for whatever went wrong.

[Viper007Bond]

Based on how Trac shows the attachment, my guess is that they are using the wrong type of line break (two byte vs. one byte or whatever).

[Viper007Bond]

Mmm, the plugin is not available for download on ​their site. Instead, you copy/paste the source of the plugin into a file. Seems their server is serving up a bad copy or whatever which results in the wrong type of line breaks, at least under Windows, or so I think.

[Sewar]

See #3269 also.

[Viper007Bond]

Replying to Sewar:

See #3269 also.

No, not related. The plugin shows up just fine, it just shows garbage (the contents of the plugin).

[robmiller]

Try converting the line breaks, then—most text editors will allow you to do this.

[JeremyVisser]

I opened the file in a hex editor and can see that all the linebreaks simply consist of a 0D, or carriage-return. This is "Mac format". Unix uses just a line-feed as a linebreak, and Windows uses a carriage-return followed by a line-feed.

I guess the parser should be made to recognise Mac-style linebreaks. By the way, does Mac OS X now use Unix-style linebreaks? I would hazard a guess that that would be true.

[AndyBeard]

Version downloaded correctly

[AndyBeard]

I just attached a version of the same plugin that was downloaded rather than viewing the page and copy/paste. If you copy and paste code in a browser, all kinds of horrible things happen. Not just line feeds, but things like quotes get very messed up.
The new version displays correctly in trak, and was tested in 2.0.4. It should work perfectly in 2.0.5 as well.
Wordpress can't reasonably be expected to fix all code that is broken due to character set conversion and browser display problems.

[Viper007Bond]

Correct, right-click -> "save link as" does indeed work. Still, is it really that hard to also look for a 0D when looking for the end of the line? Not hard.

[foolswisdom]

Viper, I am guessing you meant to reopen this.