Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#3271 closed defect (bug) (worksforme)

Plugin title / description / etc. parsing error

Reported by: viper007bond's profile Viper007Bond Owned by:
Milestone: Priority: low
Severity: trivial Version: 2.0.4
Component: Administration Keywords: needs-patch
Focuses: Cc:

Description

A client sent me this plugin. I have no f'ing clue why it shows up so horribly wrong in /wp-admin/plugins.php, but we should account for whatever went wrong.

Attachments (2)

wp-cats.php (10.1 KB) - added by Viper007Bond 16 years ago.
wp-cats-0.13.php (10.1 KB) - added by AndyBeard 16 years ago.
Version downloaded correctly

Download all attachments as: .zip

Change History (13)

@Viper007Bond
16 years ago

#1 @Viper007Bond
16 years ago

Based on how Trac shows the attachment, my guess is that they are using the wrong type of line break (two byte vs. one byte or whatever).

#2 @Viper007Bond
16 years ago

Mmm, the plugin is not available for download on their site. Instead, you copy/paste the source of the plugin into a file. Seems their server is serving up a bad copy or whatever which results in the wrong type of line breaks, at least under Windows, or so I think.

#3 follow-up: @Sewar
16 years ago

See #3269 also.

#4 in reply to: ↑ 3 @Viper007Bond
16 years ago

Replying to Sewar:

See #3269 also.

No, not related. The plugin shows up just fine, it just shows garbage (the contents of the plugin).

#5 @robmiller
16 years ago

Try converting the line breaks, then—most text editors will allow you to do this.

#6 @JeremyVisser
16 years ago

I opened the file in a hex editor and can see that all the linebreaks simply consist of a 0D, or carriage-return. This is "Mac format". Unix uses just a line-feed as a linebreak, and Windows uses a carriage-return followed by a line-feed.

I guess the parser should be made to recognise Mac-style linebreaks. By the way, does Mac OS X now use Unix-style linebreaks? I would hazard a guess that that would be true.

@AndyBeard
16 years ago

Version downloaded correctly

#7 @AndyBeard
16 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

I just attached a version of the same plugin that was downloaded rather than viewing the page and copy/paste. If you copy and paste code in a browser, all kinds of horrible things happen. Not just line feeds, but things like quotes get very messed up.
The new version displays correctly in trak, and was tested in 2.0.4. It should work perfectly in 2.0.5 as well.
Wordpress can't reasonably be expected to fix all code that is broken due to character set conversion and browser display problems.

#8 @Viper007Bond
16 years ago

Correct, right-click -> "save link as" does indeed work. Still, is it really that hard to also look for a 0D when looking for the end of the line? Not hard.

#9 @Viper007Bond
16 years ago

  • Milestone changed from 2.0.5 to 2.1
  • Priority changed from normal to low
  • Severity changed from major to trivial

#10 @foolswisdom
16 years ago

Viper, I am guessing you meant to reopen this.

#11 @Nazgul
15 years ago

  • Milestone 2.1 deleted
Note: See TracTickets for help on using tickets.