Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#32722 closed defect (bug) (fixed)

Unresponsive video embed with Firefox 38

Reported by: polyfade's profile polyfade Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2.2
Component: Media Keywords: needs-patch good-first-bug
Focuses: Cc:

Description

Using the default embed method, the video player is not responding/flexing to the width of the window specific to Firefox v38 (Mac 10.10.3). Whether this is classified as a Wordpress or Media Element issue, I'm not sure.

All other browsers display the video player just fine. Tested using a couple themes, including the default TwentyFifteen without any plugins active.

Screenshothttps://cloudup.com/caKTM38r_-T

Attachments (1)

32722.patch (559 bytes) - added by johneckman 9 years ago.
Patch to set max-width on video and overlay play button layer

Download all attachments as: .zip

Change History (11)

#1 @wonderboymusic
9 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 4.3

Needs responsive CSS for Firefox, possibly others - I gave up here:

.wp-video video,
.wp-video .mejs-container,
.wp-video .mejs-layer {
	max-width: 100%;
	height: 100%;
}

.wp-video .mejs-overlay-play {
	height: 100% !important;
}

#2 @nicholas_io
9 years ago

I could not reproduce this bug in Mac 10.10.2 with Firefox 38.0.5

#3 @johneckman
9 years ago

I am able to reproduce on Firefox 38.0.5 Mac OS 10.10.3 - actually uploading a local mp4.

Screenshot: https://cloudup.com/cUrCot47wrT

#4 @johneckman
9 years ago

Doesn't seem to be a MediaElement.js issue, as their barebones example works fine in the same setup.

Setting max-width:100% on .mejs-container does appropriately set the video width, but ends up letterboxing and not setting the height correctly.

@johneckman
9 years ago

Patch to set max-width on video and overlay play button layer

#5 @joemcgill
9 years ago

This is looks like a bug in the way mediaelement.js updates the video size and should probably be fixed upstream. Here's the related issue: https://github.com/johndyer/mediaelement/issues/920.

#6 @joemcgill
9 years ago

I submitted a patch to the mediaelement project that should resolve this issue. You can see the details here: https://github.com/johndyer/mediaelement/pull/1531.

#7 @wonderboymusic
9 years ago

  • Owner set to wonderboymusic
  • Status changed from new to assigned

We may monkey-patch for this

#8 @helen
9 years ago

  • Focuses ui removed

Removing UI focus, it is UI but basically everything ME.js as needed to be fixed in core is and I don't need to track this :)

#9 @wonderboymusic
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33267:

Monkey patch MediaElement to include a PR that restores responsive videos in Firefox:
https://github.com/johndyer/mediaelement/pull/1531

Props joemcgill.
Fixes #32722.

This ticket was mentioned in Slack in #meta by ocean90. View the logs.


9 years ago

Note: See TracTickets for help on using tickets.