WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#32732 closed enhancement (fixed)

Change "Links" title to "Custom Links" inside the menu customiser.

Reported by: paulwilde Owned by: ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

As suggested in #32710 by @afercia it makes more sense to change the "Links" title to be "Custom Links" as this would then be consistent with how its named in nav-menus.php.

Attachments (1)

32732.diff (1.6 KB) - added by paulwilde 6 years ago.

Download all attachments as: .zip

Change History (11)

@paulwilde
6 years ago

#1 @paulwilde
6 years ago

  • Keywords has-patch added

#2 @ocean90
6 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 32886:

Customizer: Rename label for custom links to "Custom Links", see [31748].

props paulwilde
fixes #32732.

#3 @celloexpressions
6 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to 4.3

The intent here was simplification. Core generally an historically has issues with overuse of a "Custom" prefix to features (Custom Headers, Custom Backgrounds, Custom Menus, etc.), and being in the Customizer already, having an extra word Custom here doesn't do much. Not necessarily opposed to this change, but I think it should be based on user testing rather than matching wp-admin.

Links are URLs, everything else is handled automatically. You don't add "Custom Links" to posts when entering a URL vs. selecting a post, it's just a link. I don't know that the word "Custom" does much to clarify this here, especially now that the add-items buttons is "Add Items" instead of "Add Links". @designsimply, what are your thoughts here?

#4 @designsimply
6 years ago

I think we should try to keep things as simple and clear as we can, whenever possible. If people became confused about what "Links" meant when they were creating menu items, that would be a good reason for changing the label, but I haven't seen that happen.

#5 @celloexpressions
6 years ago

  • Keywords revert added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Let's revert this for now and see if we run into any issues in the next round of testing. I have yet to see confusion here in the menus context. I'd rather change the "custom" label in custom menu items to "link" as that's clearer. It boils down to the idea of a link in the menu being simpler and easier to understand than the idea of a custom menu item. If needed we can use something more specific for screen readers since they'll be using different text here anyway.

#6 @ocean90
6 years ago

  • Keywords 2nd-opinion revert removed
  • Resolution set to fixed
  • Status changed from reopened to closed

Please read #31344 for why we have reverted to "Custom Links". If you think it should be something else please open a new ticket which covers both, Nav Menu screen and Customizer.

#7 follow-up: @celloexpressions
6 years ago

User testing: https://make.wordpress.org/design/2015/05/27/customizer-menus-user-testing/#comment-24603.

As far as I can tell, no user testing was considered when making this change in either place, but assumptions were asserted about how users would react to it.

#8 in reply to: ↑ 7 @samuelsidler
6 years ago

Replying to celloexpressions:

User testing: https://make.wordpress.org/design/2015/05/27/customizer-menus-user-testing/#comment-24603.

As far as I can tell, no user testing was considered when making this change in either place, but assumptions were asserted about how users would react to it.

Can we run explicit user testing on both options (with that being the only/primary change) and, if Custom or Links perform better, let's get a ticket on file for the change.

#9 follow-up: @celloexpressions
6 years ago

This is much too verbose for translations as well. We need to switch to just "Link" universally, which will be handled in #32826. The admin screen doesn't necessarily need to match - we cannot bind one UI to the other for every little tweak and plenty of things are different between them already (hence the proposal to focus on one). But I wouldn't object to changing it there also.

#10 in reply to: ↑ 9 @samuelsidler
6 years ago

Replying to celloexpressions:

We need to switch to just "Link" universally, which will be handled in #32826.

No, we need to user test both strings to ensure we're doing the right thing. It would be great if that's "Link" since it's shorter than "Custom Link." But if it's not, we need to find a workaround for #32826.

Note: See TracTickets for help on using tickets.