WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#32738 closed defect (bug) (fixed)

You can drag a parent menu item (with children) out of its container

Reported by: paulwilde Owned by: ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch dev-feedback
Focuses: javascript Cc:

Description

I've attached a video which demonstrates the problem.

Basically if a menu item has a child it's possible to drag that menu (by dragging the parent) out of its container and above the main heading and all the menu items get lost. Saving the menu restores things back to normal.

Attachments (2)

drag-and-drop-bug.mov (4.7 MB) - added by paulwilde 5 years ago.
32738.diff (559 bytes) - added by adamsilverstein 5 years ago.
Better targeting for sortable items.

Change History (7)

#1 @ocean90
5 years ago

#32764 was marked as a duplicate.

#2 @ocean90
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.3

@adamsilverstein Could you take a look at this please?

#3 @adamsilverstein
5 years ago

Yep. Will do.

@adamsilverstein
5 years ago

Better targeting for sortable items.

#4 @adamsilverstein
5 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

In 32738.diff:

  • Improve targeting for the sortableItems, resolving an issue where the first <li> in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.

#5 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 32955:

Customizer: Prevent dragging menu items above the main heading.

Improve targeting for the sortableItems, resolving an issue where the first <li> in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.

props adamsilverstein.
fixes #32738.
#wceu

Note: See TracTickets for help on using tickets.